Skip to content

The Windows package doesn't support "generic" windows (win-x64, win-x86) #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Petermarcu opened this issue Jan 19, 2018 · 9 comments
Closed

Comments

@Petermarcu
Copy link

This package https://www.nuget.org/packages/SQLitePCLRaw.lib.e_sqlite3.v110_xp/

Should have a win-x64 and win-x86 folder in it as to support people publishing applications using those runtime identifiers. The guidance for .NET Core 2.0 forward is to use those by default. Likely all that needs to happen to fix this is to move the binaries from the win7-* folder to win-*.

You can see an example of how this manifests in this issue: ElectronNET/Electron.NET#82

@ericsink
Copy link
Owner

See previous discussion on #184.

Bottom line, yes, this should happen. The only reason it has not is because my crazy build system (which I have come to loathe) makes this ultra-minor change unnecessarily risky, and I haven't gotten back to it yet.

But I do plan to have this change in 1.1.10, which should happen in the next few weeks.

@Petermarcu
Copy link
Author

Ok, I don't have enough context on your build system. In general, this should just put things in a win-* folder instead of a win7-* folder. Its a compatible change from NuGet's perspective but if there are other places where there are assumptions on this, then there could be side effects.

@ericsink
Copy link
Owner

SQLitePCL.raw pre-release version 1.1.10-pre20180223200113 has been pushed to nuget. Starting with this release, the RID for these "generic" Windows builds begins with win- instead of win7-. Let me know if you find any problems.

@tsublette
Copy link

I don't see SQLitePCL.raw pre-release version 1.1.10-pre20180223200113 on the nuget site. Only 0.9.3 https://www.nuget.org/packages/SQLitePCL.raw/

What am I missing?

@tsublette
Copy link

never mind ... read the read me... Thanks :)

@tsublette
Copy link

I have included the preview version of SQLitePCLRaw.core and SQLitePCLRaw.bundle_green.

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.0" />
    <PackageReference Include="Microsoft.AspNetCore.SignalR" Version="1.0.0-alpha2-final" />
    <PackageReference Include="Serilog.AspNetCore" Version="2.1.0" />
    <PackageReference Include="Serilog.Sinks.ColoredConsole" Version="3.0.1" />
    <PackageReference Include="SQLitePCLRaw.bundle_green" Version="1.1.10-pre20180223200113" />
    <PackageReference Include="SQLitePCLRaw.core" Version="1.1.10-pre20180223200113" />
  </ItemGroup>

and I am building the win-x64 runtime using this command

dotnet publish -c Release -r win-x64 -o /app/binaries/win-x64

and the dll - e_sqlite3.dll - is still missing from the publish folder.

Can you give me some insight into what I am doing wrong?

@ericsink
Copy link
Owner

ericsink commented Mar 5, 2018

I'm not sure.

This bat file:

mkdir t194
cd t194
dotnet new console
dotnet add package -v 1.1.10-pre20180223200113 SQLitePCLRaw.bundle_green
dotnet publish -c Release -r win-x64
dir bin\Release\netcoreapp2.0\win-x64\publish\e*.dll

shows me

 Directory of C:\Users\eric\dev\t194\bin\Release\netcoreapp2.0\win-x64\publish

02/23/2018  08:03 PM         1,238,016 e_sqlite3.dll
               1 File(s)      1,238,016 bytes

but if I change the bat file to use -v 1.1.9 in the dotnet add package line, the dir command finds nothing.

Maybe try those same commands on your system and see if you get the same result?

@tsublette
Copy link

I removed the reference to

<PackageReference Include="SQLitePCLRaw.core" Version="1.1.10-pre20180223200113" />

and kept the reference to SQLitePCLRaw.bundle_green and it worked.

Thanks for your quick response

@ericsink
Copy link
Owner

This should be fixed in 1.1.10, which is now on nuget.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants