-
-
Notifications
You must be signed in to change notification settings - Fork 116
The Windows package doesn't support "generic" windows (win-x64, win-x86) #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See previous discussion on #184. Bottom line, yes, this should happen. The only reason it has not is because my crazy build system (which I have come to loathe) makes this ultra-minor change unnecessarily risky, and I haven't gotten back to it yet. But I do plan to have this change in 1.1.10, which should happen in the next few weeks. |
Ok, I don't have enough context on your build system. In general, this should just put things in a win-* folder instead of a win7-* folder. Its a compatible change from NuGet's perspective but if there are other places where there are assumptions on this, then there could be side effects. |
SQLitePCL.raw pre-release version 1.1.10-pre20180223200113 has been pushed to nuget. Starting with this release, the RID for these "generic" Windows builds begins with win- instead of win7-. Let me know if you find any problems. |
I don't see SQLitePCL.raw pre-release version 1.1.10-pre20180223200113 on the nuget site. Only 0.9.3 https://www.nuget.org/packages/SQLitePCL.raw/ What am I missing? |
never mind ... read the read me... Thanks :) |
I have included the preview version of SQLitePCLRaw.core and SQLitePCLRaw.bundle_green.
and I am building the win-x64 runtime using this command
and the dll - e_sqlite3.dll - is still missing from the publish folder. Can you give me some insight into what I am doing wrong? |
I'm not sure. This bat file:
shows me
but if I change the bat file to use Maybe try those same commands on your system and see if you get the same result? |
I removed the reference to
and kept the reference to SQLitePCLRaw.bundle_green and it worked. Thanks for your quick response |
This should be fixed in 1.1.10, which is now on nuget.org |
This package https://www.nuget.org/packages/SQLitePCLRaw.lib.e_sqlite3.v110_xp/
Should have a win-x64 and win-x86 folder in it as to support people publishing applications using those runtime identifiers. The guidance for .NET Core 2.0 forward is to use those by default. Likely all that needs to happen to fix this is to move the binaries from the win7-* folder to win-*.
You can see an example of how this manifests in this issue: ElectronNET/Electron.NET#82
The text was updated successfully, but these errors were encountered: