Fix eldap extensibleMatch dnAttributes option #5615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
According to the ldap ASN1 the dnAttributes should be a bool, instead it was generated as a string. Also add a couple of test to verify the filter behaves correctly.
xadhoom
force-pushed
the
fix_eldap_dn_attributes
branch
from
892684d to
4e7b1f7
Compare
xadhoom
pushed a commit
to xadhoom/eldap_client
that referenced
this pull request
Jan 17, 2022
A porting of erlang/otp#5615
xadhoom
added a commit
to VoiSmart/eldap_string_filters
that referenced
this pull request
Jan 17, 2022
eldap has a bug in the dnAttributes boolean option of the extensibleMatch filter helper, where a string is set as TRUE / FALSE istead of a bool. This leads in an ASN1 error when trying to submit the request to the server. This will be removed at some time, when the OTP team fixes the issue. A PR has been opened here: erlang/otp#5615
HansN
added
in progress
testing
Contributor
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the ldap ASN1 the dnAttributes should be a bool, instead it was generated as a string.
Also add a couple of test to verify the filter behaves correctly.