Upgrade: Update devDeps and change istanbul -> nyc#130
Merged
Conversation
Member
Good idea, using ESLint v5 will probably be the easiest route. The other option could be some form of build matrix that uses older versions of ESLint on Node.js v6 and ESLint v6 everywhere else, but I don't think that's worth the effort since supporting the new processor API will require dropping support for ESLint < v6 soon anyway. |
brettz9
force-pushed
the
devDeps
branch
2 times, most recently
from
6271cc7 to
610a787
Compare
brettz9
changed the title
btmills
approved these changes
Nov 1, 2019
Member
btmills
left a comment
btmills
left a comment
There was a problem hiding this comment.
LGTM, thanks @brettz9! Looks like Travis is having issues right now, so I'll check back later and see if I can restart that build to get everything green before merging.
Update eslint-release, chai, mocha, and eslint devDeps. In process of updating, get plugins tests to work in anticipation of eslint 6.
Contributor
Author
|
Cool... Yeah, I tried with different versions of eslint including reverting, but a Travis issue makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade: Update devDeps and change istanbul -> nyc
Update eslint-release, chai, mocha, eslint devDeps. In process of updating,
get plugins tests to work in anticipation of eslint 6.
Note that this still doesn't include logic to exclude ESLint 6 in Node 6 on Travis (or, if you preferred, to bump
enginesto 8.10.0 and drop Travis testing of 6).If you like, I can also upgrade the deps. to the versions prior to breaking.