-
Notifications
You must be signed in to change notification settings - Fork 73
feat: add no-space-in-emphasis rule #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pixel998
wants to merge
5
commits into
eslint:main
Choose a base branch
from
Pixel998:no-space-in-emphasis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
@Pixel998 Make sure to mark it as ready for review once done, the team doesn't pay attention to draft PRs. |
@Pixel998 Are you still working on this? |
snitin315
reviewed
Jun 23, 2025
We have false negatives in case of nested emphasis: <!-- eslint markdown/no-space-in-emphasis: "error" -->
_ **bold** _ // no error
This is * italic with __ bold __ markdown * // No error reported
This is *italic with __ bold __ markdown* // Reports error for bold emphasis as expected |
snitin315
reviewed
Jun 23, 2025
Following is an edge case, I'm not sure if we want to solve for it in the initial version. **** bold **** // No error, |
lumirlumir
reviewed
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR implements the no-space-in-emphasis rule to disallow spaces around emphasis markers.
What changes did you make? (Give an overview)
Implemented the no-space-in-emphasis rule, along with documentation and tests.
Related Issues
Fixes #378
Is there anything you'd like reviewers to focus on?