feat: add checkMissingCells option to table-column-count #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
reviewed
Jun 23, 2025
snitin315
previously approved these changes
Jun 26, 2025
lumirlumir
requested changes
Jun 26, 2025
lumirlumir
requested changes
Jun 30, 2025
| @@ -43,7 +43,7 @@ Examples of **correct** code for this rule: | |||
| <!-- Rows with fewer cells are valid because they render correctly and no data is lost --> | |||
| | Header | Header | Header | | |||
| | ------ | ------ | ------ | | |||
| | Cell | Cell | | | |||
| | Cell | Cell | | |||
There was a problem hiding this comment.
Suggested change
| | Cell | Cell | | |
| | Cell | Cell | | |
I think the original intention of this example is to show that an empty cell is okay. The following example already covers the change you made.
Could you revert the example?
There was a problem hiding this comment.
Its description says: <!-- Data row with fewer cells than header (VALID for this rule) -->. Without this change, the number of cells would have matched the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This pull request introduces a new option, checkMissingCells, to the table-column-count rule. The purpose of this addition is to provide users with more granular control over how the rule handles tables with missing cells, allowing for stricter or more flexible enforcement as needed.
What changes did you make? (Give an overview)
Related Issues
Fixes #422
Is there anything you'd like reviewers to focus on?