Twig template label is null when adding templates

[aksm]

What?

While investigating/testing #315, I got this error:

TypeError: Twig\Source::__construct(): Argument #2 ($name) must be of type string, null given, called in /var/www/html/web/modules/contrib/format_strawberryfield/src/Entity/MetadataDisplayEntity.php on line 423 in Twig\Source->__construct() (line 30 of /var/www/html/vendor/twig/twig/src/Source.php)

The label is null here for newly added templates:

format_strawberryfield/src/Entity/MetadataDisplayEntity.php

Line 423 in 74d68f9

$source = new Source($twigtemplate, $this->label(), '');

I guess I had never tested getTwigVariablesUsed() while adding a new template? Or something else has changed? Will investigate further.

[DiegoPino]

@aksm, sadly there are too many issues in Format SBF related to this new piece of code. I should have done a more deeper tested code review on your pull. I can not get around deprecation errors rendering but e.g not triggering views on templates and it is not clear to me if Pat's comment is or not valid + plus this one. This piece of archipelago is core. I will try (12AM here) to revert the changes to a previous state in a while. And when I come back we will have to re-work the code into archipelago. Won't remove the actual getVariables code from the entity itself but I will remove the usage on the preview. We talked about this with @alliomeria and we agree stability wins here. Thanks

[DiegoPino]

resolved via 663b0fa