Skip to content

Add extra \Error catching on Metadata Display Preview #380

@DiegoPino

Description

@DiegoPino

What?

Well the are catching exceptions, but some errors like passing less arguments than expected to a twig extension are ERRORS that don't extend Exception class but are still Throwables. By adding an extra catch we can also show those to the user. The Message descriptions are NOT the best sadly for those, but at least they are a better hint than a PHP error log that is not visible to the user + empty Ajax response.

How to test? break your template like this
image

you will see that the preview never returns and is invisible to the user. With the new code the user will see this

image

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions