ISSUE-125: Full screen view cut in half w/ OpenSeadragon viewer

[pcambra]

This PR removes the container class from the iiif div so the width is always 100%.
Also some minor coding style fixes

Fixes #125

[DiegoPino]

Awesome @pcambra. single css fix 👏 but with the DCS it touches a lot of code so took me a bit longer to review.
There is one line you removed that needs to go back but also needs to be fixed (and issue on my part) and tested (by clearing caches and starting new annotations, the changing user, etc) the code way this works is also good to explore for you. Thanks a lot

Also, about the file cache. We normally do not remove @TODO except if we are over them or we get them fixed or they are not relevant. In this case I do not know enough to be sure if the file cache should be taken in account here or not. If you feel its not needed all good and we are over this, but if not, either leave the comment there or if you feel so add them a cache tag(s) for the actual render array.

[DiegoPino]

This here seems to be a bug/of mine
WebAnnotationController::primeKeyStore() should be primed with the $keystoreid. Issue was this whole thing is cached and gets actually never call again after a cache clear. So wondering if it can be removed totally OR, better not and we need to prime it, at least once to avoid problems when the cache expires (e.g because of Node edit).

Can you please change to to WebAnnotationController::primeKeyStore($keystoreid) ?

[pcambra]

Done

[DiegoPino]

Almost! Sorry again (what a day!) its not $elements[$delta] its $items[$delta], $elements[$delta] its an render array, $items[$delta] the actual field with JSON data.

[pcambra]

Oops sorry about that!

[DiegoPino]

yep. what a shame! sloppy iterative code. Thanks!

[DiegoPino]

Wonder if we should add the file cache tags instead of removing this? (Given its and not Solved @TODO) or do you think it is not needed?

[pcambra]

Aw sorry about that, we're not doing anything with the tags so maybe some more work is needed for this?

[DiegoPino]

No problem. Let's keep the //@todo for now and remove 240. We can work on that in another issue. Thanks

[DiegoPino]

Hey. I will merge this. We can deal with the @todo another day. I have done the cache stuff on the WARC formatter so we can copy from there. Thanks!

[pcambra]

I've added the cache tags to the element delta, is that what would be intended?

[DiegoPino]

And this the actual fix! Good. Good.

[DiegoPino]

Still need to wait for tomorrow to merge because of the non initialized (my fault) storage. Let's get that done and we move from there. I will merge the Twig editor in the meantime!

[DiegoPino]

Hi Pedro, sorry again. I explained myself wrong here: It is both, look at the primeKeyStore signature.

/**
   * Primes the Web Annotation KeyStore with saved values.
   *
   * @param \Drupal\strawberryfield\Plugin\Field\FieldType\StrawberryFieldItem $itemfield
   * @param null $keystoreid
   */
  public static function primeKeyStore(StrawberryFieldItem $itemfield,  $keystoreid = NULL) {
    if ($keystoreid == NULL && strlen(trim($keystoreid)) == 0) {
      return NULL;
    }
    $jsondata = $itemfield->provideDecoded(TRUE);
    $tempstore = \Drupal::service('tempstore.private')->get(
      'webannotation'
    );
    if (!empty($jsondata['ap:annotationCollection']) && is_array($jsondata['ap:annotationCollection'])) {
      $tempstore->set($keystoreid, $jsondata['ap:annotationCollection']);
      return $jsondata['ap:annotationCollection'];
    }
    else {
      $tempstore->set($keystoreid, []);
      return [];
    }
  }
``` this won't work that way. You can look at how we call this in other parts.

The issue I had was that I was passing only the $items[$delta] when we already know where we want the keystore to be primed. But also this needs some little testing if you could. Thanks

[pcambra]

Ah I see that now, not sure why PHPStorm didn't call me out when I did that

[DiegoPino]

And merging. Thanks @pcambra !