ISSUE-395: Make IP based embargoed ADOs + Anonymous users un-cacheable #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bool, true == cacheable result, false == we won't cache. Used to add extra info outside / at the caller level. e.g cache-time, etc. For anonymous users, and in the presence of IP embargo metadata we opt out of caching. This was tested several times by forcing drupal messages (when no caching is enabled any hit on a page that contains non cacheable ADOs will show a message and also stop any further caching) and checking headers
Every formatter now has the right context/tags but also
if (isset($embargo_info[4]) && $embargo_info[4] === FALSE) {
$elements['#cache']['max-age'] = 0;
}
to ensure that browsers don't keep anything around (for those moving in/out of campus wide IP allowances/restrictions)
also some smaller cleanups
DiegoPino
added
bug
Member
Author
|
This needs also a re-roll for 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #395
This has been tested a lot. But I will give my today's self a bit of slack, test again later tonight and merge. Solves the issue with Anonymous users from a different IP/Network seen a stale cache generated by other anonymous users + makes also cache more robust on all viewers + brings to 2023 the simpler image formatter nobody uses (a "classic")