ISSUE-400: Advanced Search Classic mode #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Notes for myself:
|
We don't act on these yet. On classic mode the default behavior (invisible to the user) will be to render all allowed filters BUT hide them initially. That way the plus and minus signs really only do "show/hide" and unset values instead of depending on a complex logic on the Actual exposed form handler for the filter. This also allows the Filter still have full control of how many/naming, etc. All this via JS
…idding (visually hidden v/s hidden via js?) or data attributes? not sure yet
'aria-hidden' = TRUE allows us to also hide them for screen readers. If not this is just too confusing for an enduser
…c mode Works. No submit until user presses "Apply" or search or whatever the "op" button is named. But... i still need to refine the remove logic. Bc as "requested" there could be a MINUS button per sub filter, which means also, when someone presses [add]. i Basically need to reorder the values so there are no "empty" gaps which right now happens when i hide/unhide elements,. Baby steps @alliomeria
Member
Author
|
marked this as ready for review bc the logic works 100%. With improved JS. But, the UX need still work. Why?
|
…istent order (i tried, god knows i tried @alliomeria) but, i can shift and move values so i can always remove from the end, add to the end, but delete the value from the actual position i am requested and via JS move values one step down. Which in UX terms i like if i had actually removed the specific field...
…st one now Edge case, the last one is the current one... deal with that Diego @alliomeria this will be ready to test tomorrow 9AM
Yay diego, yay
And now i got it right advanced_search_multiple_remove
DiegoPino
added
enhancement
DiegoPino
added
Sub Modules
Contributor
|
This is great @DiegoPino! So far all testing in local has been going very well, no issues using either modern/regular modality for the interactions or with the 'classic' mode setup. Next week, will work with you to pass some potential default configurations (views, facets, etc) to pair with these for standard deployments. Thank you and have a great weekend! :D |
Member
Author
|
@alliomeria thanks so much for all the extensive testing. Same for you, happy weekend 🐶 🌷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #400
This is ready to be tested.
New settings:
Classic mode basically uses JS for everything but keeps the sequential logic of fields named with a suffix
_$countand ordered. Does not solve the other need (facet summaries)