ISSUE-453: Fixes Override Windows (array) loosing Manifest ID when overridden #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To test at this to the Settings
{
"windows": [{
"thumbnailNavigationPosition": "far-right"
}]
}
@alliomeria 👀
DiegoPino
added
bug
Member
Author
|
@alliomeria we could also totally remove from the per Window setting that defines where the Bar goes, and just leave the "default" you shared as driving factor. That would also make new windows also default to that position. We can talk tomorrow about that |
Member
Author
|
@alliomeria I missed merging this for the release. Will merge now and will update composer locks tomorrow AM. Not a big deal |
Contributor
|
Ok, all good, thank you @DiegoPino |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #453
To test, add this to the settings (Mirador settings are confusing.. this is how you put the thumbnail navigation for the first opened window to the right.
{ "windows": [{ "thumbnailNavigationPosition": "far-right" }] }@alliomeria 👀