refactor: rename import map utility functions for better semantic clarity #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rity - Rename buildImportsMap → createImportsMap for better semantic meaning - Rename buildScopesMap → createScopesMap for better semantic meaning - Rename fixNestedScopesResolution → fixImportMapNestedScopes for better semantic meaning - Rename getImportMap → createImportMap for better semantic meaning - Update all function references and imports - Update comments to reflect cross-browser compatibility issues - Update test cases to use new function names - All tests pass successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the import map utility functions to have more semantically clear names that better reflect their actual purpose and functionality.
Changes
Function Renames
Additional Improvements
Rationale
The original function names were not semantically clear:
The new names provide better clarity about what each function actually does, improving code readability and maintainability.
Testing
Breaking Changes
This is a breaking change for any external code that imports these utility functions directly. Internal usage within the Esmx framework has been updated accordingly.