fix: preserve original error in async component loading #232
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update error handling in route-transition.ts to include original error message - Update test to verify original error is preserved in error message - Remove unused import in test file
Deploying esmx with
|
| Latest commit: |
2dec381
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bc31e0be.esmx.pages.dev |
| Branch Preview URL: | https://fix-preserve-original-error.esmx.pages.dev |
lzxb
deleted the
fix/preserve-original-error-in-async-component-loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where original error information was lost when async component loading failed. Previously, when an async component threw an error, the error handler would catch it but throw a new error without preserving the original error message, making debugging difficult.
Changes Made
route-transition.tsto capture and include the original error message in the new errorroute-transition.test.tsto verify that the original error is preservedRelated links
N/A
Checklist