Update LLVM and GCC#527
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the toolchain versions for both LLVM and GCC to their latest releases. The changes add support for LLVM esp-20.1.1_20250829 and update the default GCC version to esp-15.2.0_20250920.
- Add support for LLVM version esp-20.1.1_20250829 with corresponding logic updates
- Update default GCC release from 14.2.0_20241119 to 15.2.0_20250920
- Update changelog to document these version bumps
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/toolchain/llvm.rs | Adds LLVM 20 support with new constant and integration into version detection logic |
| src/toolchain/gcc.rs | Updates default GCC release version constant |
| CHANGELOG.md | Documents the toolchain version updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } else if (major == 1 && minor == 88 && patch == 0 && subpatch == 0) | ||
| || (major == 1 && minor < 88) |
There was a problem hiding this comment.
The version comparison logic appears incorrect. The condition (major == 1 && minor < 88) will match versions like 1.87.x which should use LLVM 19, but the minor == 88 && patch == 0 && subpatch == 0 condition suggests 1.88.0.0 specifically should use LLVM 19. This creates ambiguous version mapping where 1.88.x versions might not be handled consistently.
No description provided.