flush() is a TX related function

[JAndrassy]

WiFiClient.flush should send all data from tx buffer. it is not true that in Arduino world it is a rx buffer thing. the Client class is inherited from Print class and the flush method is from Print. And in Print implementations the flush is a tx thing. And the reference for the Client class implementation is Ethernet library.

[d-a-v]

Duplicate of issue #1002.
This has been very recently fixed by #3967 and is currently in git master (not 2.4.0-rc2).

[devyte]

Closing as duplicate of #1002 .

[d-a-v]

@JAndrassy (from #3967)

and moving flush() from Stream to Print?

The ::flush() beeing a tx not rx stuff was #1002's point and fix is merged.
::flush() in arduino is declared in Print:: which is inherited by Stream::, and our flush() is declared only in Stream::.

So you were suggesting for moving it to Print:: ?
Can you please elaborate ?

[JAndrassy]

flush() accompanies write functions in Print. so yes it should be in Print. Stream adds read functions. flush() is important for effective implementations of write() with buffering.

btw: most Arduino users (programmers) do not use flush(). Therefore in my implementations of Print (mostly derived from Stream or Client) I add flush into available() if rx buffer is empty and tx buffer is not sent. It is much better the sending by one byte over some protocol with frame bytes overhead.

[d-a-v]

Since current implementation does not exactly follows arduino's core library, this is a fair proposal.
Have you considered making yourself a pull request for this ?

[JAndrassy]

no, because it would take to much time for me to fork the project and set it up for testing

[d-a-v]

I hope you'll have time to try #4029