Add a workaround-delay in Serial.flush() #3714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In relation to #2536 and #2502 Tested at 80MHz and 160MHz with flash-frequency at both 40MHz and 80MHz, the bug mentioned in the above issues manifests in all cases. The proposed workaround seems to work fine, I tested at 2400bps, 9600bps, 115200bps, 230400bps and 2Mbps and didn't see anomalous output.
devyte
reviewed
Oct 13, 2017
cores/esp8266/HardwareSerial.cpp
Outdated
| @@ -152,6 +152,9 @@ void HardwareSerial::flush() | |||
| } | |||
|
|
|||
| uart_wait_tx_empty(_uart); | |||
| //Workaround for a bug in serial not actually being finished yet | |||
| //Wait for 8 data bits, 1 parity and 2 stop bits, just in case | |||
| delayMicroseconds(1100000 / uart_get_baudrate(_uart) + 1); | |||
There was a problem hiding this comment.
Your original comment in the issue said this worked:
delayMicroseconds((int)(1000000.0 / uart_get_baudrate(_uart) * 11 + 1))
There is a difference of a factor of 10. Which is correct?
There was a problem hiding this comment.
1000000 * 11 == 11000000. Nuff said.
There was a problem hiding this comment.
Yes, but 1100000 != 11000000
I think your PR is missing a zero.
There was a problem hiding this comment.
Yeah, good catch. I don't know how that did happen.
d-a-v
pushed a commit
to d-a-v/Arduino
that referenced
this pull request
Oct 15, 2017
* Add a workaround-delay in Serial.flush() In relation to esp8266#2536 and esp8266#2502 Tested at 80MHz and 160MHz with flash-frequency at both 40MHz and 80MHz, the bug mentioned in the above issues manifests in all cases. The proposed workaround seems to work fine, I tested at 2400bps, 9600bps, 115200bps, 230400bps and 2Mbps and didn't see anomalous output. * Remove extraneous character * Update HardwareSerial.cpp
This was referenced Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #2536 and #2502
Tested at 80MHz and 160MHz with flash-frequency at both 40MHz and 80MHz, the bug mentioned in the above issues manifests in all cases. The proposed workaround seems to work fine, I tested at 2400bps, 9600bps, 115200bps, 230400bps and 2Mbps and didn't see anomalous output.