add option to override fingerprint with * #4510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some projects which make requests from a remote server that requires https, putting a fingerprint in the code is not an option because it may change at any moment.
This gives the ability to make https requests using a "" to intentionally override the fingerprint verification. Using the "" rather than omitting it completely makes it apparent that it is intentionally being overridden. While this may be slightly less secure in some cases, depending on the user's application it may also add a lot of functionality.
For example,
http.begin("https://www.meethue.com/api/nupnp", "*");