Skip to content

Update boards.txt.py #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update boards.txt.py #4613

wants to merge 1 commit into from

Conversation

4dsystems
Copy link
Contributor

Need to change flash mode from qio to dio, due to a change in supplier of Flash Memory. Old modules work just the same with no speed difference noticed, new modules will not work without the change to dio however.

Need to change flash mode from qio to dio, due to a change in supplier of Flash Memory. Old modules work just the same with no speed difference noticed, new modules will not work without the change to dio however.
@earlephilhower
Copy link
Collaborator

Almost there. You also need to run the modified script once to generate the new boards.txt, since it's not normally executed as part of the setup (Windows users often don't have Python) and include it in the patch. Just run it and git add boards.txt; git commit -a --amend; git push and you should be all set with this PR.

@4dsystems
Copy link
Contributor Author

Sorry I have no idea how to do that. I have just edited the file on github site, we dont have the tools installed on the machine. Are you able to assist please?

@earlephilhower
Copy link
Collaborator

Unfortunately I can't edit your branch where this is coming from, but you should be able to do it from the web for this small of a patch. For larger changes it's definitely not recommended!

Just go to your GitHub repo, select the patch-2 branch, edit the 1 spot this will change in boards from txt, save the edits to the existing branch, and they'll appear as a new commit in this PR automatically.

@4dsystems
Copy link
Contributor Author

I forked the clone into a repo on our account, and went to the patch-2 branch, and the change was already present there...

@earlephilhower
Copy link
Collaborator

Yes, the file is there but it doesn't have the QIO->dio change in it. You can run the boards.txt.py to generate it, git commit -a --amend; git push it, and you'll be set. Right now your patch (see top link of the PR) only includes the .py change, not the output...

@4dsystems
Copy link
Contributor Author

how do you call 'git commit -a --amend; git push' etc from the website? Or do I have to have git installed on my computer or something? I am a hardware guy, and this I am really struggling with.

@d-a-v
Copy link
Collaborator

d-a-v commented Apr 6, 2018

@4dsystems if the change is only qio to dio, we can make it for you

d-a-v added a commit to d-a-v/Arduino that referenced this pull request Apr 7, 2018
on behalf of @4dsystems esp8266#4613:
Need to change flash mode from qio to dio, due to a change in supplier of
Flash Memory.  Old modules work just the same with no speed difference
noticed, new modules will not work without the change to dio however.
d-a-v added a commit that referenced this pull request Apr 8, 2018
on behalf of @4dsystems #4613:
Need to change flash mode from qio to dio, due to a change in supplier of Flash Memory.
Old modules work just the same with no speed difference noticed,
new modules will not work without the change to dio however.
@d-a-v d-a-v closed this Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants