Skip to content

added 2M generic boards #5404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 1, 2018
Merged

added 2M generic boards #5404

merged 13 commits into from
Dec 1, 2018

Conversation

apicquot
Copy link
Contributor

2M (SPIFFS 128K)
2M (SPIFFS 256K)

used python board.txt.py --allgen as requested and added the proper flash mapping in board.txt.py

Alexandre Picquot and others added 2 commits November 30, 2018 16:29
earlephilhower
earlephilhower requested changes Nov 30, 2018
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many unnecessary files in this push, please remove them.

Fix the indenting on boards.txt.py

In the end for this change I think we'd only see commits only in boards.txt.py and boards.txt

Alexandre Picquot added 2 commits November 30, 2018 17:01
removed unecessary files
ac24693 
corrected ident in board.py
ld files regenerated with new name convention: 1.0M / 2.0M instead of 1M / 2M
Merge branch 'added_2M_boards_flash_mapping' of https://github.com/ap…
ae166c4 
…icquot/Arduino into added_2M_boards_flash_mapping
@apicquot
Copy link
Contributor Author

many files generated because names for ld files have changed 1M, 2M becoming 1.0M 2.0M...

@devyte
Copy link
Collaborator

devyte commented Nov 30, 2018

I see .orig files here.

earlephilhower
earlephilhower requested changes Nov 30, 2018
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've now actually deleted necessary LD files instead of just uncommitting changes against them. Please fix.

apicquot and others added 2 commits November 30, 2018 22:16
@apicquot
restored:
6acbab8 
tools/sdk/ld/eagle.app.v6.common.ld.h
tools/sdk/ld/eagle.app.v6.common.ld.vtables.h
tools/sdk/ld/eagle.rom.addr.v6.ld
@apicquot
Merge branch 'master' into added_2M_boards_flash_mapping
de8fc03
@apicquot
Copy link
Contributor Author

apicquot commented Dec 1, 2018

sorry for the mistakes. should be good now

@earlephilhower earlephilhower merged commit 4b16fa0 into esp8266:master Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apicquot @devyte @earlephilhower @d-a-v