[Proposal] Clarify (the existence of) the constant empty String #5546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of use of naked global symbol.
jjsuwa
force-pushed
the
clarify_const_empty_String
branch
from
afd32a7 to
9335115
Compare
earlephilhower
approved these changes
Dec 26, 2018
devyte
requested changes
Jan 3, 2019
| @@ -70,6 +72,9 @@ class String { | |||
| explicit String(double, unsigned char decimalPlaces = 2); | |||
| ~String(void); | |||
|
|
|||
| // empty string singleton | |||
| static constexpr const String& empty = ::__emptyString; | |||
There was a problem hiding this comment.
Please don't call the static member "empty". It should be ok to also call it "emptyString", because it is scoped, or call it something else (emptyStr, nullString, defString, etc)
There was a problem hiding this comment.
Given the deprecation, can this be implemented the other way around? make this member the "real" object, and make the global a reference to this one.
|
@jjsuwa ping! |
|
@jjsuwa Are you going to make a new PR for this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of use of naked global symbol.