Skip to content

LEAmDNS fixes 1 #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

LEAmDNS fixes 1 #5611

wants to merge 2 commits into from

Conversation

LaborEtArs
Copy link
Contributor

  • Better separation of ESP wifi thread code from user thread code
  • Added a flag for 'update()'-less use (disabled by default)
  • The too fast updates for service queries are fixed
  • Switched fully to PolledTimeout; LEATimeFlag not needed anymore (BTW: a const 'expired()' method would be helpful)
  • The device should stay visible now even after the first TTL timeout
  • Improved service querying (queries five times now)

@LaborEtArs
Fixes 1
3140611 
- Better separation of ESP wifi thread code from user thread code
- Added a flag for 'update()'-less use (disabled by default)
- The too fast updates for service queries are fixed
- Switched fully to PolledTimeout; LEATimeFlag not needed anymore (BTW: a const 'expired()' method would be helpful)
- The device should stay visible now even after the first TTL timeout
- Improved service querying (queries five times now)
@LaborEtArs
LEAmDNS fixes 1
6b43b52 
- Better separation of ESP wifi thread code from user thread code
- Added a flag for 'update()'-less use (disabled by default)
- The too fast updates for service queries are fixed
- Switched fully to PolledTimeout; LEATimeFlag not needed anymore (BTW: a const 'expired()' method would be helpful)
- The device should stay visible now even after the first TTL timeout
- Improved service querying (queries five times now)
@devyte
Copy link
Collaborator

devyte commented Jan 14, 2019

Something is strange in this PR. I see brand new files, and no changes at all to existing files.
Maybe the files are in the wrong dir?

@d-a-v
Copy link
Collaborator

d-a-v commented Jan 14, 2019 •
edited
Loading

Indeed.
@LaborEtArs Can you "git move" your files into library/ESP8266mDNS/src/ and repush ?

@LaborEtArs
Copy link
Contributor Author

Can do and would love to do, but haven’t got a clue, what your talking about (at least don’t know how to move files via git) ☹️

@d-a-v d-a-v mentioned this pull request Jan 14, 2019
Closed
@d-a-v
Copy link
Collaborator

d-a-v commented Jan 15, 2019

closed in favor of #5619

@d-a-v d-a-v closed this Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaborEtArs @devyte @d-a-v