Skip to content

Fixes issue #5744 #5745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes issue #5744 #5745

wants to merge 1 commit into from

Conversation

oddstr13
Copy link
Contributor

@oddstr13 oddstr13 commented Feb 8, 2019

Initialize UdpContext _pcb->local_ip.type with IPADDR_TYPE_ANY in dual-stack mode.

MCVE output before patch (release 2.5.0)

17:21:12.024205 IP 10.79.2.187.52506 > 8.8.8.8.18888: UDP, length 7
17:21:23.032132 IP 10.79.2.187.52506 > 8.8.8.8.18888: UDP, length 7

SDK:3.0.0-dev(c0f7b44)/Core:2.5.0=20500000/lwIP:IPv6+STABLE-2_1_2_RELEASE/glue:1.1/BearSSL:6778687

sta config unchangedscandone
.scandone
state: 0 -> 2 (b0)
state: 2 -> 3 (0)
state: 3 -> 5 (10)
add 0
aid 6
cnt 

connected with Solvang, channel 6
dhcp client start...
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
Connected! IP address: 10.79.2.187
----------------------------------
Sending UDP packet to 8.8.8.8 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: 1
----------------------------------
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
Sending UDP packet to 2001:4860:4860::8888 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: :ust rc=-6
0
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
pm open,type:2 0
----------------------------------
Sending UDP packet to 8.8.8.8 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: 1
----------------------------------
Sending UDP packet to 2001:4860:4860::8888 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: :ust rc=-6
0
----------------------------------
Sending UDP packet to 8.8.8.8 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: 1
----------------------------------
Sending UDP packet to 2001:4860:4860::8888 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: :ust rc=-6
0
----------------------------------

MCVE output after patch

(one initial fail, due to no IPv6 yet)

17:30:26.970618 IP 10.79.2.187.61998 > 8.8.8.8.18888: UDP, length 7
17:30:37.976476 IP 10.79.2.187.61998 > 8.8.8.8.18888: UDP, length 7
17:30:38.974241 IP6 2a02:<snip>.61998 > 2001:4860:4860::8888.18888: UDP, length 7
17:30:48.981904 IP 10.79.2.187.61998 > 8.8.8.8.18888: UDP, length 7
17:30:49.980760 IP6 2a02:<snip>.61998 > 2001:4860:4860::8888.18888: UDP, length 7

SDK:3.0.0-dev(c0f7b44)/Core:2.5.0=20500000/lwIP:IPv6+STABLE-2_1_2_RELEASE/glue:1.1/BearSSL:6778687

sta config unchangedscandone
.scandone
state: 0 -> 2 (b0)
state: 2 -> 3 (0)
state: 3 -> 5 (10)
add 0
aid 6
cnt 

connected with Solvang, channel 6
dhcp client start...
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
Connected! IP address: 10.79.2.187
----------------------------------
Sending UDP packet to 8.8.8.8 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: 1
----------------------------------
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
Sending UDP packet to 2001:4860:4860::8888 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: :ust rc=-4
0
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
ip:10.79.2.187,mask:255.255.252.0,gw:10.79.0.1
pm open,type:2 0
----------------------------------
Sending UDP packet to 8.8.8.8 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: 1
----------------------------------
Sending UDP packet to 2001:4860:4860::8888 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: 1
----------------------------------
Sending UDP packet to 8.8.8.8 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: 1
----------------------------------
Sending UDP packet to 2001:4860:4860::8888 port 18888
Udp.beginPacket: 1
Udp.write: 7
Udp.endPacket: 1
----------------------------------

@oddstr13
Fixes issue esp8266#5744
7e9b45c 
Initialize UdpContext `_pcb->local_ip.type` with `IPADDR_TYPE_ANY` in dual-stack mode.
@oddstr13
Copy link
Contributor Author

oddstr13 commented Feb 8, 2019

Not really a major contribution, but in any case;

I dedicate any and all copyright interest in this software to the
public domain. I make this dedication for the benefit of the public at
large and to the detriment of my heirs and successors. I intend this
dedication to be an overt act of relinquishment in perpetuity of all
present and future rights to this software under copyright law.

@oddstr13 oddstr13 mentioned this pull request Feb 8, 2019
Closed
6 tasks
oddstr13 added a commit to oddstr13/esp82xx-nonos-linklayer that referenced this pull request Feb 11, 2019
@oddstr13
core/udp.c:udp_new: Initialize pcb->local_ip.type depending on whet…
cae2ad6 
…her we have IPv4, IPv4+IPv6 or IPv6 networking stack.

Fixes esp8266/Arduino#5744
Closes esp8266/Arduino#5745
@oddstr13 oddstr13 mentioned this pull request Feb 11, 2019
Merged
d-a-v pushed a commit to d-a-v/esp82xx-nonos-linklayer that referenced this pull request Feb 11, 2019
@oddstr13 @d-a-v
core/udp.c:udp_new: Initialize pcb->local_ip.type depending on whet…
0e0dc7f 
…her we have IPv4, IPv4+IPv6 or IPv6 networking stack. (#28)

Fixes esp8266/Arduino#5744
Closes esp8266/Arduino#5745
d-a-v added a commit to d-a-v/Arduino that referenced this pull request Feb 11, 2019
@d-a-v
lwip2: ipv6: fix udp_new() esp8266#5744
cf504df 
From: @oddstr13
(d-a-v/esp82xx-nonos-linklayer#28)

Initialize pcb->local_ip.type depending on whether we have IPv4, IPv4+IPv6 or IPv6 networking stack.

Fixes esp8266#5744
Closes esp8266#5745
@d-a-v d-a-v mentioned this pull request Feb 11, 2019
Merged
d-a-v added a commit to oddstr13/esp8266-Arduino that referenced this pull request Feb 11, 2019
@d-a-v
lwip2: ipv6: fix udp_new() esp8266#5744 (esp8266#5752)
5f68e61 
From: @oddstr13
(d-a-v/esp82xx-nonos-linklayer#28)

Initialize pcb->local_ip.type depending on whether we have IPv4, IPv4+IPv6 or IPv6 networking stack.

Fixes esp8266#5744
Closes esp8266#5745
someburner pushed a commit to someburner/esp82xx-nonos-linklayer that referenced this pull request Feb 16, 2019
@oddstr13 @someburner
core/udp.c:udp_new: Initialize pcb->local_ip.type depending on whet…
7f85f2a 
…her we have IPv4, IPv4+IPv6 or IPv6 networking stack. (#28)

Fixes esp8266/Arduino#5744
Closes esp8266/Arduino#5745
oddstr13 added a commit to oddstr13/UKHASnet-ESP-GWv2 that referenced this pull request Aug 17, 2022
@oddstr13
Initial support for IPv6 Multicast
0808b01 
Requires upstream patch esp8266/Arduino#5745
Which is not present in v2.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oddstr13