udp: restore correct address/port when parsing packet #6011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devyte
requested changes
Apr 24, 2019
- separate variable declaration from struct declaration - cammelCase - in-place constructor: avoid empty constructor then initialisation - add in-place call to destructor also improved pbuf usage
devyte
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
One comment + one question.
As discussed, please add the explanation about pbuf and the ALIGNER macro.
Is there consistency in ordering of the pbufs within the pbuf chain, considering multiple UdpContext instances that could be receiving different things?
// first rx_buf contains an address helper
...
// ... next one is effective data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store IPaddresses/ports in another lwIP's pbuf next to and in sequence with the one holding actual data to guarantee coherence.
fix #5960