Upgrade to 2.5.0-4 toolchain w/improved pgm_read_x, C++ exceptions #6273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebuild the entire toolchain (including standard libraries) with the latest pgm_read_xxx headers included (which fix unaligned dword reads from progmem and run faster/smaller, and a pgm_read_byte change which removes an instruction on each read saving flash). Pull in latest bearssl while we're at it, too, which speeds up EC handshakes and reduced ROM usage, too.
earlephilhower
changed the title
earlephilhower
changed the title
earlephilhower
changed the title
|
As we've just found issues w/exceptions, it makes sense to hold off on this until we backport the 9.1 changes to 4.8. |
earlephilhower
force-pushed
the
to_2.5.0-4
branch
2 times, most recently
from
a2081f1 to
a750f52
Compare
Apply the GCC9.1 patches (with needed changes) to GCC4.8. Exception code now only does 32b aligned reads from progmem to access the eh_table (some via -mforce-l32, some via hand-inserted pgm_read_x macros).
earlephilhower
force-pushed
the
to_2.5.0-4
branch
from
a750f52 to
dc80836
Compare
earlephilhower
changed the title
Now works as expected (remember, regexes are broken in GCC until after 5.2, so the regex_error is expected): |
|
Fixes #6305 |
6 tasks
d-a-v
approved these changes
Jul 21, 2019
earlephilhower
force-pushed
the
to_2.5.0-4
branch
from
4f1fc6d to
e05f328
Compare
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuild the entire toolchain (including standard libraries) with the
latest pgm_read_xxx headers included (which fix unaligned dword reads
from progmem and run faster/smaller, and a pgm_read_byte change which
removes an instruction on each read saving flash).
Pull in latest bearssl while we're at it, too, which speeds up EC
handshakes and reduces ROM usage, too.