Skip to content

exceptions: optionally enforce c++ standards #6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Aug 28, 2019
Merged

exceptions: optionally enforce c++ standards #6333

merged 28 commits into from
Aug 28, 2019

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jul 23, 2019

#6312 restored "arduino new" 's right to return nullptr

This PR optionally allows to enforce C++ standards by making new call abort in case of OOM.

It also introduces an optional allocator to allow a clean behaviour in case of oom.

check maintainers' effort to document new without exceptions .

@d-a-v d-a-v requested review from earlephilhower and devyte July 23, 2019 10:09
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job summarizing the infinite loop of the new discussion.

@d-a-v
Copy link
Collaborator Author

d-a-v commented Jul 31, 2019

Benefits brought by the new allocator: example output

@TD-er
Copy link
Contributor

TD-er commented Jul 31, 2019

infinite loop of the new discussion.

That's a true statement in itself :)

@d-a-v
Copy link
Collaborator Author

d-a-v commented Jul 31, 2019

Thanks @earlephilhower for reminding #4639 (allowing the last commit)

@d-a-v d-a-v merged commit 85f1ea7 into esp8266:master Aug 28, 2019
@d-a-v d-a-v deleted the new0 branch August 28, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants