Refactor HardwareSerial.cpp for consistent use of PolledTimeout #6371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dok-net
changed the title
dok-net
changed the title
dok-net
force-pushed
the
hwser_consistency
branch
from
f2b0682 to
70c904e
Compare
dok-net
changed the title
dok-net
force-pushed
the
hwser_consistency
branch
from
70c904e to
08da6d2
Compare
dok-net
changed the title
dok-net
force-pushed
the
hwser_consistency
branch
from
08da6d2 to
8195b17
Compare
dok-net
force-pushed
the
hwser_consistency
branch
from
8195b17 to
244d656
Compare
d-a-v
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After quick review comment, both of the two places in HardwareSerial.cpp shall use PolledTimeout - fixed by this PR.