Run makecorever.py before specific prebuild hooks. #6504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a sketch needs information that is in `core_version.h`, you have to build a dummy sketch 1st to get `core_version.h` created. Since `core_version.h` is created after the sketch is compiled. Moved rebuild recipe hook for running `makecorever.py` core to run before all _specific_ prebuild hooks. While this form of prebuild hook is not explicitly listed, it seems like an intuitive expectation. Recipie hooks of this form: ``` recipe.hooks.prebuild.NUMBER.pattern=... ``` build before recipies of this form: ``` recipe.hooks.SPECIFIC.prebuild.NUMBER.pattern=... ``` where `SPECIFIC` would be: sketch, libraries, core, linking, ...
d-a-v
approved these changes
Sep 12, 2019
earlephilhower
approved these changes
Sep 12, 2019
devyte
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sketch needs information that is in
core_version.h, youhave to build a dummy sketch 1st to get
core_version.hcreated.Since
core_version.his created after the sketch is compiled.Moved prebuild recipe hook for running
makecorever.pycore to runbefore all specific prebuild hooks. While this form of prebuild hook
is not explicitly listed, it seems like an intuitive expectation and works.
Recipie hooks of this form:
build before recipies of this form:
where
SPECIFICwould be: sketch, libraries, core, linking, ...Update: corrected typo