-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add missing time.h include, use relative include path on time.h includes #6730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Done, except for the examples - since those don't use external libraries anyways I don't think it makes sense to change those (CMIIW). |
If you have this library, windows or macOS, and if you can compile&run these examples, then it's fine. |
That's the case, unless you specifically link it against the Time library (which for an example would be weird).
In my opinion FS.h should have a time.h include, because it calls time(). You can't really rely on the parent code to include the header file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a comment on each changed line stating compat with Time lib, see issue #6714 or along those lines.
Added missing time.h include. The path is relative (instead of simply using
<time.h>
) so it doesn't conflict with Time.h of the Arduino Time library. See #6714 (comment) for details.