Update SdFat to not undefine F() macro #6787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes esp8266#6767 . Remove the `undef F` from SysCall.h as it is not needed nor used in the SD or SDFS libraries. This puts F() strings back in flash when using the SD/SDFS libs.
|
That leaves the question, why it was undef'ed in the first place? |
|
He has several strings in the examples and core for status prints which use printf() which, several versions ago, did not support PROGMEM automatically w/o any change needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6767 . Remove the
undef Ffrom SysCall.h as it is not needednor used in the SD or SDFS libraries. This puts F() strings back in
flash when using the SD/SDFS libs.