Fix AsyncWebServer when building for Arduino SDK 2.0.0-rc1 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: src/WebHandlerImpl.h
.piolibdeps/esp32-test/ESPAsyncWebServer-esphome/src/AsyncWebSocket.cpp: In member function 'IPAddress AsyncWebSocketClient::remoteIP()':
.piolibdeps/esp32-test/ESPAsyncWebServer-esphome/src/AsyncWebSocket.cpp:832:29: error: call of overloaded 'IPAddress(long unsigned int)' is ambiguous
return IPAddress(0UL);
^
In file included from /root/.platformio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:163,
from .piolibdeps/esp32-test/ESPAsyncWebServer-esphome/src/AsyncWebSocket.cpp:21:
/root/.platformio/packages/framework-arduinoespressif32/cores/esp32/IPAddress.h:51:5: note: candidate: 'IPAddress::IPAddress(const uint8_t*)'
IPAddress(const uint8_t *address);
^~~~~~~~~
/root/.platformio/packages/framework-arduinoespressif32/cores/esp32/IPAddress.h:50:5: note: candidate: 'IPAddress::IPAddress(uint32_t)'
IPAddress(uint32_t address);
^~~~~~~~~
…th-arduino-esp32-2.0.0-rc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to build against latest Arduino SDK 2.0.0-rc1 for ESP32/ESP32-C3 by fixing two build-time issue: One issue related to type differences (fixed by explicit type cast) and by not using deprecated mbedtls functions.
It also fixes a use-after-free issue when iterating over HTTP heather, which lead to a crash on RISC-V based ESP32-C3 (fixes esphome/issues#2257). This issue is not specific to RISC-V, but seems not lead to a crash on Xtensa based CPUs so far.