This repository was archived by the owner on Jan 14, 2022. It is now read-only.
Beautify #1
Open
Beautify #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the changes is a wrong dash-character in a command line example in README.md: it would not work as originally written. The other changes are double quotes and colons in English text: no functional difference.
For international users of the library, this is much more readable. TODO: can someone please translate the comment in dhcpserver.h to English?
With GIT repositories, it is best practice to check in all text files that do not _require_ \r\n line endings even on Linux and Mac with pure \n line endings. See https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#Formatting-and-Whitespace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains three changes:
TODO: can someone please translate the comment in dhcpserver.h to English?