Update HTTPUpdateServer.h to Fix SPIFFS Update error: Bad Size Given

[kapyaar]

if (!Update.begin(SPIFFS.totalBytes(), U_SPIFFS)) {

throws an error "Update error: Bad Size Given". Changing to

if (!Update.begin(UPDATE_SIZE_UNKNOWN, U_SPIFFS)) {

fixes #9967. Submitting a PR as per #9967 (comment)

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Warnings

⚠️

Some issues found for the commit messages in this PR: the commit message "Update HTTPUpdateServer.h": summary looks empty type/action looks empty the commit message "fix(HTTPUpdateServer): Remove SPIFFS.h include": scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - . Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello kapyaar, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b977457

[Jason2866]

@me-no-dev is it planned to replace the dead horse spiffs with LittleFS in HTTPUpdateServer?

[me-no-dev]

Actually here the size of the FS partition should be read and used. Code can be abstracted to flash any FS type, instead of just SPIFFS

[kapyaar]

If there is a better approach to handle this, Please update or let me know, I can do another PR. One way or the other, It would be great to get this fixed, as at this point, with each release (for backward compatibility), a manual update of this file is the only way out.

[github-actions]

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32C5	💚 -9K	0	💚 -0.85	0.00	💚 -32	0	💚 -0.06	0.00
ESP32P4	💚 -9K	0	💚 -1.02	0.00	💚 -16	0	💚 -0.05	0.00
ESP32S3	💚 -6K	0	💚 -0.67	0.00	💚 -32	0	💚 -0.07	0.00
ESP32S2	💚 -7K	0	💚 -0.72	0.00	💚 -32	0	💚 -0.07	0.00
ESP32C3	💚 -9K	0	💚 -0.90	0.00	💚 -32	0	💚 -0.08	0.00
ESP32C6	💚 -9K	0	💚 -0.89	0.00	💚 -24	0	💚 -0.05	0.00
ESP32	💚 -6K	0	💚 -0.65	0.00	💚 -24	0	💚 -0.05	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32C5		ESP32P4		ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/HTTPUpdateServer/examples/WebUpdater	💚 -9K	💚 -32	💚 -9K	💚 -16	💚 -6K	💚 -32	💚 -7K	💚 -32	💚 -9K	💚 -32	💚 -9K	💚 -24	💚 -6K	💚 -24

[me-no-dev]

Sorry for the delay! Will be part of 3.3.1 tomorrrow