feat(touch): Support all touch versions in NG driver#11643
Merged
feat(touch): Support all touch versions in NG driver#11643
Conversation
Contributor
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Contributor
Test Results144 files 144 suites 40m 54s ⏱️ Results for commit 6b91048. ♻️ This comment has been updated with latest results. |
Contributor
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
P-R-O-C-H-Y
added
Status: Review needed
Member
Author
|
@me-no-dev @SuGlider @lucasssvaz PR is ready to me reviewed. HW CI test is failing but it works locally. |
Member
Author
|
All good now. Also CI tests are passing. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a unified touch sensor driver that supports all ESP32 variants (ESP32, ESP32-S2, ESP32-S3, ESP32-P4) by replacing the legacy touch implementation with the modern NG driver. The change improves reliability and maintainability while introducing a breaking change for ESP32's touchInterruptSetThresholdDirection() function.
- Unified NG driver implementation supporting all ESP32 variants with version-specific configurations
- Updated examples and tests to use the new touch API and simplified threshold handling
- Breaking change: ESP32
touchInterruptSetThresholdDirection()must be called before pin setup
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/validation/touch/touch.ino | Updated test to use unified threshold logic and reduced test channels |
| tests/validation/touch/ci.json | Added verbose debug logging for tests |
| libraries/ESP32/examples/Touch/TouchRead/TouchRead.ino | Changed from T1 to T2 pin for consistency |
| libraries/ESP32/examples/Touch/TouchInterrupt/TouchInterrupt.ino | Simplified threshold handling with benchmark-based approach |
| libraries/ESP32/examples/Touch/TouchButtonV2/* | Removed V2-specific example (now unified) |
| libraries/ESP32/examples/Touch/TouchButton/* | Updated to use unified touch API with status checking |
| cores/esp32/esp32-hal-touch.h | Added IDF version check for legacy driver |
| cores/esp32/esp32-hal-touch.c | Added IDF version check for legacy driver |
| cores/esp32/esp32-hal-touch-ng.h | Extended NG driver to support all ESP32 variants |
| cores/esp32/esp32-hal-touch-ng.c | Implemented unified NG driver with chip-specific configurations |
| CMakeLists.txt | Added touch sensor driver requirement for all supported chips |
| .github/scripts/tests_run.sh | Added verbose output flag for pytest |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
me-no-dev
approved these changes
Aug 29, 2025
me-no-dev
added
Status: Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR introduces a unified touch sensor driver that supports all ESP32 variants (ESP32, ESP32-S2, ESP32-S3, ESP32-P4) with improved reliability and maintainability. The legacy touch implementation has been replaced with the modern NG driver, and all related examples and tests have been updated accordingly.
BREAKING CHANGE:
For ESP32
touchInterruptSetThresholdDirection(bool mustbeLower)can now be used only before setting up the touch pin.Tests scenarios
Tested using ESP32, ESP32-S2, ESP32-S3 and P4.
Related links
Closes #11637