Skip to content

fix(python): Fixes for Python code scanning alerts#11668

Merged
me-no-dev merged 5 commits intomasterfrom
fix/py
Sep 5, 2025
Merged

fix(python): Fixes for Python code scanning alerts#11668
me-no-dev merged 5 commits intomasterfrom
fix/py

Conversation

@lucasssvaz
Copy link
Member

@lucasssvaz lucasssvaz commented Jul 29, 2025 •
edited
Loading

Description of Change

This pull request fixes issues reported by CodeQL. Mostly files which are not closed if an exception occurs.

Requires #11676

Tested locally.

@lucasssvaz lucasssvaz self-assigned this Jul 29, 2025
@lucasssvaz lucasssvaz added the Area: Tools & Build System Issue is related to tools and/or the build system label Jul 29, 2025
@lucasssvaz lucasssvaz requested a review from me-no-dev as a code owner July 29, 2025 13:57
@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 03d0566

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C50‼️ +8K0.00⚠️ +0.76000.000.00
ESP32P40‼️ +8K0.00‼️ +1.06000.000.00
ESP32S30‼️ +7K0.00⚠️ +0.72000.000.00
ESP32S20‼️ +7K0.00⚠️ +0.78000.000.00
ESP32C30‼️ +8K0.00⚠️ +0.79000.000.00
ESP32C60‼️ +8K0.00⚠️ +0.78000.000.00
ESP32H2000.000.00000.000.00
ESP320‼️ +7K0.00⚠️ +0.740⚠️ +1080.00⚠️ +0.22
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ArduinoOTA/examples/BasicOTA‼️ +8K0‼️ +8K0‼️ +7K0‼️ +7K0‼️ +8K0‼️ +8K0--‼️ +7K⚠️ +108
libraries/BLE/examples/Server00--00--00000000
libraries/Insights/examples/MinimalDiagnostics00--00000000--00
libraries/NetworkClientSecure/examples/WiFiClientSecure000000000000--00
libraries/WebServer/examples/HttpAdvancedAuth‼️ +8K0‼️ +8K0‼️ +6K0‼️ +6K0‼️ +8K0‼️ +8K0--‼️ +6K⚠️ +108
libraries/WebServer/examples/HttpAuthCallback‼️ +8K0‼️ +8K0‼️ +6K0‼️ +6K0‼️ +8K0‼️ +8K0--‼️ +6K⚠️ +108
libraries/WebServer/examples/HttpAuthCallbackInline‼️ +8K0‼️ +8K0‼️ +6K0‼️ +6K0‼️ +8K0‼️ +8K0--‼️ +6K⚠️ +108
libraries/WebServer/examples/HttpBasicAuth‼️ +8K0‼️ +8K0‼️ +6K0‼️ +6K0‼️ +8K0‼️ +8K0--‼️ +6K⚠️ +108
libraries/WebServer/examples/HttpBasicAuthSHA1‼️ +8K0‼️ +8K0‼️ +6K0‼️ +6K0‼️ +8K0‼️ +8K0--‼️ +6K⚠️ +108
libraries/WebServer/examples/HttpBasicAuthSHA1orBearerToken‼️ +8K0‼️ +8K0‼️ +6K0‼️ +6K0‼️ +8K0‼️ +8K0--‼️ +6K⚠️ +108
libraries/ESP32/examples/Camera/CameraWebServer----0000------00
ESP32/examples/Camera/CameraWebServer (2)----0000------00
ESP32/examples/Camera/CameraWebServer (3)----00----------

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 30, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 1, 2025
View reviewed changes
@lucasssvaz lucasssvaz requested review from a team and SuGlider as code owners August 1, 2025 16:42
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 1, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025 •
edited
Loading

Test Results

 76 files   76 suites   13m 11s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 03d0566.

♻️ This comment has been updated with latest results.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 1, 2025
View reviewed changes
@lucasssvaz lucasssvaz requested a review from P-R-O-C-H-Y August 1, 2025 22:33
@lucasssvaz lucasssvaz added the Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first label Aug 1, 2025
@lucasssvaz lucasssvaz added the Status: Review needed Issue or PR is awaiting review label Aug 21, 2025
SuGlider
SuGlider previously requested changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it seems contaminated with Hash changes from #11676

@lucasssvaz
Copy link
Member Author

lucasssvaz commented Aug 27, 2025

I think that it seems contaminated with Hash changes from #11676

As it is written in the description it requires the hashing changes. It will be rebased once they are merged. You can still review the python codes as it wont change

@lucasssvaz lucasssvaz removed the Status: Blocked upstream 🛑 PR is waiting on upstream changes to be merged first label Sep 4, 2025
@lucasssvaz lucasssvaz requested a review from SuGlider September 4, 2025 16:39
@lucasssvaz lucasssvaz force-pushed the fix/py branch 2 times, most recently from 1a198e8 to ffaca1b Compare September 4, 2025 16:58
@me-no-dev
Copy link
Member

me-no-dev commented Sep 5, 2025

@P-R-O-C-H-Y @SuGlider PTAL

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Sep 5, 2025
@github-actions github-actions bot added the Status: Pre-commit fixes required ⚠️ The pre-commit bot can't fix the issues automatically. Please fix the issues manually. label Sep 5, 2025
@me-no-dev
Copy link
Member

me-no-dev commented Sep 5, 2025

@lucasssvaz some issue here: https://github.com/espressif/arduino-esp32/actions/runs/17489249358/job/49675046357?pr=11668#step:8:27

@github-actions github-actions bot removed the Status: Pre-commit fixes required ⚠️ The pre-commit bot can't fix the issues automatically. Please fix the issues manually. label Sep 5, 2025
@me-no-dev me-no-dev merged commit 7436eab into master Sep 5, 2025
77 checks passed
@me-no-dev me-no-dev deleted the fix/py branch September 5, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@SuGlider SuGlider Awaiting requested review from SuGlider

Assignees

@lucasssvaz lucasssvaz

Labels

Area: Tools & Build System Issue is related to tools and/or the build system Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucasssvaz @me-no-dev @SuGlider @P-R-O-C-H-Y