You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request
This entire section above can be deleted if all items are checked.
Description of Change
Setting the proper RGB led pin in the header code to GPIO35
Tests scenarios
I have tested my pull request on an AtomS3-Lite with Blink.ino and BlinkRGB.ino (Exemples>ESP32>GPIO>BlinkRGB)
The schematics of the AtomS3 (non-lite) shows the LED also connected to GPIO35
👋 Hello brice-fr, we appreciate your contribution to this project!
📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.
Please consider the following: - Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes. - Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues. - Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it. - To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
Review and merge process you can expect ...
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer. 2. They review the PR and either approve it or ask you for changes or clarifications. 3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing. - At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation. 4. If the change is approved and passes the tests it is merged into the default branch.
brice-fr
changed the title
Update pins_arduino.h of variant m5stack_atoms3 with correct LED_BUILTIN value matching GPIO #35
fix(esp32:m5stack_atoms3) : Update pins_arduino.h of variant m5stack_atoms3 with correct LED_BUILTIN value matching GPIO #35
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Setting the proper RGB led pin in the header code to GPIO35
Tests scenarios
I have tested my pull request on an AtomS3-Lite with Blink.ino and BlinkRGB.ino (Exemples>ESP32>GPIO>BlinkRGB)
The schematics of the AtomS3 (non-lite) shows the LED also connected to GPIO35
Related links
Fixes #11688
HW Doc for AtomS3
HW Doc for AtomS3-Lite