Skip to content

Add Support for Twin AIoT Module#11718

Closed
bekirr12 wants to merge 0 commit into
espressif:masterfrom
bekirr12:master
Closed

Add Support for Twin AIoT Module#11718
bekirr12 wants to merge 0 commit into
espressif:masterfrom
bekirr12:master

Conversation

@bekirr12
Copy link
Copy Markdown
Contributor

@bekirr12 bekirr12 commented Aug 12, 2025 •
edited
Loading

Description of Change
This pull request adds support for the "Twin AIoT Module" to the Arduino-ESP32 core. As a product developed by our company, "Twin Science", we aim to make it easily accessible and usable for all our users directly within the Arduino IDE.

The "Twin AIoT Module" is a development board based on the "ESP32-S3-MINI-1" chip. It features "led matrix", "touchpad", "rgb led", "analog and digital pins". The board's pin definitions and configuration have been carefully prepared and tested.

Tests scenarios
I have tested this pull request on my "Twin AIoT Module".

The tests were performed using the Arduino IDE 2.3.6.

The following scenarios were tested successfully:

Basic Functionality: The classic "Blink", "Serial Monitor", "RGB Led", "Led Matrix" examples worked as expected, confirming core functionality and proper board selection.

GPIOs: A series of digital and analog I/O tests were performed to verify the correctness of the pinout definitions.

Connectivity: Wi-Fi and Bluetooth examples were run successfully to confirm wireless connectivity.

Related Library

@bekirr12 bekirr12 requested a review from P-R-O-C-H-Y as a code owner August 12, 2025 13:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 12, 2025 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Docs: Update boards.txt for ESP32-S3-N4R2 module":
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello bekirr12, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 94e0459

@lucasssvaz lucasssvaz added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Aug 12, 2025
@bekirr12
Copy link
Copy Markdown
Contributor Author

bekirr12 commented Aug 18, 2025

Hello, when will the approval process be completed? Is there anything I need to do?

@P-R-O-C-H-Y
Copy link
Copy Markdown
Member

P-R-O-C-H-Y commented Aug 21, 2025

Hi @bekirr12, can you add a link to docs or product page? What ESP32S3 module is used, as you kept all the PSRAM and FlashSize options.

P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Aug 21, 2025
View reviewed changes
Comment thread variants/twinaiot/pins_arduino.h Outdated
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Awaiting Response Awaiting a response from the author label Aug 21, 2025
@bekirr12
Copy link
Copy Markdown
Contributor Author

bekirr12 commented Aug 21, 2025

We don't have our own dedicated product page. We're using the ESP32S3-MINI-1 chip. Normally, we'd install it by selecting the ESP32S3 Dev Module on the Arduino IDE. However, we'd like to add our own product name to make it easier for our customers to understand.

esp32s3-mini-1 doc

@P-R-O-C-H-Y
Copy link
Copy Markdown
Member

P-R-O-C-H-Y commented Aug 21, 2025

We don't have our own dedicated product page. We're using the ESP32S3-MINI-1 chip. Normally, we'd install it by selecting the ESP32S3 Dev Module on the Arduino IDE. However, we'd like to add our own product name to make it easier for our customers to understand.

esp32s3-mini-1 doc

But to make it even easier, if you manufacture using the same modules, which exactly is that?
ESP32-S3-MINI-1-N8 have 8MB Flash and no PSRAM
ESP32-S3-MINI-1-N4R2 have 4MB FLASH and 2MB PSRAM

According to module used, you can delete unsupported options in the boards.txt

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Aug 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick

Comment thread boards.txt Outdated
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Awaiting Response Awaiting a response from the author labels Aug 22, 2025
@P-R-O-C-H-Y
Copy link
Copy Markdown
Member

P-R-O-C-H-Y commented Aug 22, 2025

@bekirr12 please resolve conflicts so we are able to merge.

@bekirr12 bekirr12 closed this Aug 22, 2025
@bekirr12
Copy link
Copy Markdown
Contributor Author

bekirr12 commented Aug 22, 2025 via email

@bekirr12
Copy link
Copy Markdown
Contributor Author

bekirr12 commented Aug 22, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

No one assigned

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bekirr12 @P-R-O-C-H-Y @lucasssvaz