feat(rmt): adds new function to send specific number of loops#11748
Merged
feat(rmt): adds new function to send specific number of loops#11748
Conversation
Adds a new function `rmtWriteLoopingCount()` to send a specific number of times, repeating the same RMT Symbols.
Contributor
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Adds: bool rmtWriteLoopingCount(int pin, rmt_data_t *data, size_t num_rmt_symbols, uint32_t loop_count) It will send a pattern defined by `*data` RMT Symbols for `loop_count` times (repeated). This is different from `rmtWriteLooping()`, which will repeat it for ever (endless looping).
SuGlider
commented
Aug 20, 2025
SuGlider
commented
Aug 20, 2025
Contributor
Test Results 76 files 76 suites 13m 17s ⏱️ Results for commit ba60ffa. ♻️ This comment has been updated with latest results. |
Contributor
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SuGlider
commented
Sep 5, 2025
SuGlider
commented
Sep 6, 2025
SuGlider
commented
Sep 6, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new RMT function rmtWriteRepeated() that allows transmitting RMT data patterns a specific number of times, providing a middle ground between single transmission and infinite looping.
Key changes:
- Adds
rmtWriteRepeated()function with loop count parameter - Modifies internal
_rmtWrite()function to support finite loop counts - Updates documentation to clarify looping behavior differences
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cores/esp32/esp32-hal-rmt.h | Adds function declaration and updates documentation for the new repeated write functionality |
| cores/esp32/esp32-hal-rmt.c | Implements the core logic for repeated transmission with finite loop counts |
| libraries/ESP32/examples/RMT/RMT_LED_Blink/RMT_LED_Blink.ino | Adds example usage demonstrating the new repeated write function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
me-no-dev
approved these changes
Sep 10, 2025
me-no-dev
added
Status: Pending Merge
github-actions
bot
added
the
Status: Pre-commit fixes required ⚠️
SuGlider
commented
Sep 10, 2025
github-actions
bot
removed
the
Status: Pre-commit fixes required ⚠️
github-project-automation
bot
moved this from In Review
to Done
in Arduino ESP32 Core Project Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds a new function
rmtWriteRepeated()to send a specific number of times, repeating the same RMT Symbols.Adds:
bool rmtWriteRepeated(int pin, rmt_data_t *data, size_t num_rmt_symbols, uint32_t loop_count)It will send a pattern defined by
*dataRMT Symbols forloop_counttimes (repeated).This is different from
rmtWriteLooping(), which will repeat it for ever (endless looping).Note: ESP32 doesn't support SOC_RMT_SUPPORT_TX_LOOP_COUNT
Test Scenarios
Tested with ESP32 and ESP32-S3.
Based on the example modified in the PR (RMT_LED_Blink.ino)
Related links
Closes #11731