fix(board): Fix wESP32 board config with new options#11879
fix(board): Fix wESP32 board config with new options#11879me-no-dev merged 3 commits intoespressif:masterfrom
Conversation
- Provide flash size option to choose 4MB flash (rev 5 and below) or 16MB flash (default, rev 7 and higher). - Provide appropriate partition scheme options to effectively us either 4MB or 16MB flash sizes. - Change default Ethernet PHY from LAN8720 to RTL8201 (rev 7 and higher).
👋 Hello xorbit, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
| @@ -35,7 +35,7 @@ static const uint8_t T9 = 32; | |||
| #define ETH_PHY_POWER -1 | |||
| #define ETH_PHY_MDC 16 | |||
| #define ETH_PHY_MDIO 17 | |||
There was a problem hiding this comment.
What about having also #define ETH_PHY_TYPE_REV4 ETH_PHY_LAN8720 in case someone uses the old revision to keep backward compatibility.
There was a problem hiding this comment.
In my examples, I have usually called out just setting all parameters:
https://wesp32.com/software/#arduino-esp32
With the change in this PR, users now could just use ETH.begin() for any wESP32 sold in the last 4 years.
The only revisions ever sold are rev 3, 4 and 5 with LAN8720, sold for about 3 years (2018 ~ 2021), and rev 7 and 8 with RTL8201, sold the last 4 years (2021 ~ present). I'm not sure how to clearly communicate what another define would be for exactly. It's not just revision 4, it's 3, 4 and 5 you'd use LAN8720 for. I don't see how any new #define we'd come up with would be clearer than to just say "this board needs LAN8720" and use the ETH_PHY_LAN8720 name directly.
Checklist
Description of Change
Test Scenarios
Tested on Arduino 2.3.6 locally with wESP32 rev 8 board.