fix(wifi): Do not use persistent mode with ESP-Hosted#12043
Merged
fix(wifi): Do not use persistent mode with ESP-Hosted#12043
Conversation
Contributor
👋 Hello me-no-dev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Contributor
Test Results 76 files 76 suites 19m 28s ⏱️ Results for commit 43b5d49. ♻️ This comment has been updated with latest results. |
Contributor
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucasssvaz
approved these changes
Nov 19, 2025
Member
lucasssvaz
left a comment
lucasssvaz
left a comment
There was a problem hiding this comment.
LGTM. What is the issue when persistence is enabled ?
Member
Author
credentials are stored on the C6 and that causes issues in some cases. @TD-er had a case also. Change was recommended from the hosted team |
Contributor
|
Yep, the C6 could even (re)connect when I just wiped the flash of the P4 and tried to start fresh without any wifi credentials present in ESPEasy. |
P-R-O-C-H-Y
approved these changes
Nov 20, 2025
P-R-O-C-H-Y
added
Status: Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a configuration change to the WiFi initialization process to improve compatibility when using esp-hosted mode. The main update ensures that NVS (Non-Volatile Storage) is disabled and persistent storage is turned off when the remote WiFi feature is enabled.
WiFi initialization compatibility:
WiFiGeneric.cpp, added a conditional block that disables NVS (cfg.nvs_enable = false) and setspersistent = falsewhenCONFIG_ESP_WIFI_REMOTE_ENABLEDis defined, ensuring proper operation with esp-hosted setups.