refactor(wifi): Refactor WiFi sleep modes

[szerwi]

Description of Change

Refactor WiFiGenericClass::setSleep() and WiFiGenericClass::getSleep() functions.

WiFiGenericClass::setSleep() was returning false when requested mode was the same as already set, which is not expected behavior.

I have refactored functions logic, unified variables names, removed unused variable _forceSleepLastMode from WiFiGenericClass.

---

I am not sure if this ifdef should be kept. Is there any reason to disable modem sleep for ESP32 S2? I haven't found any info about it in ESP-IDF docs.

Test Scenarios

Tested on v3.3.4 and ESP32 DevKit

Related links

[github-actions]

	Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello szerwi, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 443cfba

[github-actions]

Test Results

 76 files   76 suites   15m 42s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 443cfba.

♻️ This comment has been updated with latest results.

[github-actions]

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32C5	0	0	0.00	0.00	0	0	0.00	0.00
ESP32P4	0	0	0.00	0.00	0	0	0.00	0.00
ESP32S3	0	⚠️ +4	0.00	0.00	0	0	0.00	0.00
ESP32S2	0	⚠️ +4	0.00	0.00	0	0	0.00	0.00
ESP32C3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C6	0	0	0.00	0.00	0	0	0.00	0.00
ESP32H2	0	0	0.00	0.00	0	0	0.00	0.00
ESP32	0	⚠️ +4	0.00	0.00	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32C5		ESP32P4		ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/ArduinoOTA/examples/BasicOTA	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/AsyncUDP/examples/AsyncUDPClient	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/AsyncUDP/examples/AsyncUDPMulticastServer	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/AsyncUDP/examples/AsyncUDPServer	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/DNSServer/examples/CaptivePortal	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/ESP32/examples/Time/SimpleTime	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Master	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Slave	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/ESP_NOW/examples/ESP_NOW_Network	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/ESP_NOW/examples/ESP_NOW_Serial	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/ESPmDNS/examples/mDNS-SD_Extended	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/ESPmDNS/examples/mDNS_Web_Server	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Ethernet/examples/ETH_WIFI_BRIDGE	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/FFat/examples/FFat_time	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPClient/examples/Authorization	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPClient/examples/BasicHttpClient	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPClient/examples/BasicHttpsClient	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPClient/examples/CustomHeaders	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPClient/examples/HTTPClientEnterprise	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPClient/examples/ReuseConnection	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPClient/examples/StreamHttpClient	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPUpdate/examples/httpUpdate	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPUpdate/examples/httpUpdateSPIFFS	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPUpdate/examples/httpUpdateSecure	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/HTTPUpdateServer/examples/WebUpdater	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Insights/examples/DiagnosticsSmokeTest	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Insights/examples/MinimalDiagnostics	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/LittleFS/examples/LITTLEFS_time	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Matter/examples/MatterColorLight	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterCommissionTest	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterComposedLights	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterContactSensor	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterDimmableLight	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterEnhancedColorLight	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterEvents	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterFan	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterHumiditySensor	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterMinimum	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterOccupancySensor	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterOnIdentify	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterOnOffLight	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterOnOffPlugin	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterPressureSensor	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterSmartButton	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterTemperatureLight	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterTemperatureSensor	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/Matter/examples/MatterThermostat	0	0	-	-	0	0	0	0	0	0	0	0	0	0	0	0
libraries/NetBIOS/examples/ESP_NBNST	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/NetworkClientSecure/examples/WiFiClientInsecure	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/NetworkClientSecure/examples/WiFiClientPSK	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/NetworkClientSecure/examples/WiFiClientSecure	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/NetworkClientSecure/examples/WiFiClientSecureEnterprise	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/NetworkClientSecure/examples/WiFiClientShowPeerCredentials	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/NetworkClientSecure/examples/WiFiClientTrustOnFirstUse	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/PPP/examples/PPP_WIFI_BRIDGE	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/RainMaker/examples/RMakerCustom	0	0	-	-	0	0	0	0	0	0	0	0	-	-	-	-
libraries/RainMaker/examples/RMakerCustomAirCooler	0	0	-	-	0	0	0	0	0	0	0	0	-	-	-	-
libraries/RainMaker/examples/RMakerSonoffDualR3	0	0	-	-	0	0	0	0	0	0	0	0	-	-	-	-
libraries/RainMaker/examples/RMakerSwitch	0	0	-	-	0	0	0	0	0	0	0	0	-	-	-	-
libraries/SD/examples/SD_time	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/SPIFFS/examples/SPIFFS_time	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Update/examples/AWS_S3_OTA_Update	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Update/examples/HTTPS_OTA_Update	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Update/examples/HTTP_Client_AES_OTA_Update	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Update/examples/HTTP_Server_AES_OTA_Update	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Update/examples/OTAWebUpdater	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/AdvancedWebServer	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/ChunkWriting	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/FSBrowser	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/Filters	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/HelloServer	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/HttpAdvancedAuth	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/HttpAuthCallback	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/HttpAuthCallbackInline	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/HttpBasicAuth	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/HttpBasicAuthSHA1	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/HttpBasicAuthSHA1orBearerToken	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/Middleware	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/MultiHomedServers	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/PathArgServer	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/SDWebServer	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/SimpleAuthentification	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/UploadHugeFile	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/WebServer	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WebServer/examples/WebUpdate	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/FTM/FTM_Initiator	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/FTM/FTM_Responder	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/SimpleWiFiServer	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WPS	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiAccessPoint	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiBlueToothSwitch	0	0	-	-	0	0	-	-	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiClient	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiClientBasic	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiClientConnect	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiClientEnterprise	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiClientEvents	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiClientStaticIP	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiExtender	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiIPv6	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiMulti	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiMultiAdvanced	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiScan	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiScanAsync	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiScanDualAntenna	0	0	0	0	⚠️ +4	0	⚠️ +4	0	0	0	0	0	-	-	⚠️ +4	0
libraries/WiFi/examples/WiFiScanTime	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiSmartConfig	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiTelnetToSerial	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFi/examples/WiFiUDPClient	0	0	0	0	0	0	0	0	0	0	0	0	-	-	0	0
libraries/WiFiProv/examples/WiFiProv	0	0	-	-	0	0	0	0	0	0	0	0	-	-	0	0
libraries/Zigbee/examples/Zigbee_Gateway	0	0	-	-	0	0	0	0	0	0	-	-	-	-	0	0
libraries/SD_MMC/examples/SDMMC_time	-	-	0	0	0	0	-	-	-	-	-	-	-	-	0	0
libraries/ESP32/examples/Camera/CameraWebServer	-	-	-	-	⚠️ +4	0	⚠️ +4	0	-	-	-	-	-	-	⚠️ +4	0
ESP32/examples/Camera/CameraWebServer (2)	-	-	-	-	⚠️ +4	0	⚠️ +4	0	-	-	-	-	-	-	⚠️ +4	0
ESP32/examples/Camera/CameraWebServer (3)	-	-	-	-	⚠️ +4	0	-	-	-	-	-	-	-	-	-	-

[me-no-dev]

most of the changes are renaming variables. That makes reading your changes really hard. Please revert var names!

[szerwi]

most of the changes are renaming variables. That makes reading your changes really hard. Please revert var names!

@me-no-dev sure, I will revert that. Should I use old var names, which are not accurate in some cases, or can I correct them and split those changes into 2 commits (logic change & vars renaming)?

[me-no-dev]

please use the old names and only provide the logic changes. In a separate PR you can rename the variables later

[szerwi]

@me-no-dev Var names reverted