fix(ble): Add missing modifier keys for HID Keyboard#12093
fix(ble): Add missing modifier keys for HID Keyboard#12093me-no-dev merged 2 commits intoespressif:masterfrom
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 18m 2s ⏱️ Results for commit 78f8552. ♻️ This comment has been updated with latest results. |
Description of Change
This pull request updates the
HIDKeyboardTypes.hheader to improve clarity and flexibility in handling keyboard modifier keys. The main focus is on expanding and clarifying the definitions of modifier keys, introducing both left and right variants, and using bitwise definitions for better compatibility.Modifier key improvements:
BIT()macro, making them clearer and more maintainable. (KEY_CTRL,KEY_SHIFT,KEY_ALT)KEY_LEFT_CTRL,KEY_RIGHT_CTRL, etc.), and included the GUI (Windows/Command) key for both sides.esp_bit_defs.hheader to provide theBIT()macro used in the new definitions.Related links
Closes #12084