fix(recipes): fixes platform.txt for older arduino-build version#12189
fix(recipes): fixes platform.txt for older arduino-build version#12189
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Added a note about whitespace to avoid bugs in older versions of arduino-builder.
bjscheue
left a comment
There was a problem hiding this comment.
The last addition to the comment is wrong. It's not about the line length, there is no 500 character limit. It's about the parser in arduino-builder processing the line incorrectly if there is a quote (') character that is directly followed by a whitespace.
Thanks! Done. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a compatibility issue with Arduino IDE 1.x on Linux and CI systems using arduino-builder version 1.3. The issue manifested as a bash parsing error ("unexpected EOF while looking for matching `''") when building sketches, caused by how older arduino-builder versions handle quotes followed by whitespace in platform.txt recipe patterns.
Key Changes:
- Removed whitespace around redirection operators (
>,>>) and logical AND operators (&&) in the bash command that generates the flash_args file - Added an explanatory comment documenting the workaround for the arduino-builder bug
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@bjscheue - It doesn't work with Arduino IDE 2. |
Retesting it again. It seems that Arduino IDE got lost with the changes. It may work fine. |
|
I have tested it with Win11 and IDE 2.3.7 + IDE 1.8.19 -- all fine so far. |
Description of Change
Some users have reported issues with IDE 1.x based on Linux and issues with CI that relies on Arduino Packages that need arduino-build 1.3
This PR has a small fix that seems to solve such issue as stated by @bjscheue in #12159 (comment)
Test Scenarios
CI and using IDE to build basic sketches.
Related links
Closes #12159