Skip to content

fix(recipes): fixes platform.txt for older arduino-build version#12189

Merged
me-no-dev merged 4 commits intomasterfrom
fix/old_arduino_build_compatibility
Jan 12, 2026
Merged

fix(recipes): fixes platform.txt for older arduino-build version#12189
me-no-dev merged 4 commits intomasterfrom
fix/old_arduino_build_compatibility

Conversation

@SuGlider
Copy link
Collaborator

Description of Change

Some users have reported issues with IDE 1.x based on Linux and issues with CI that relies on Arduino Packages that need arduino-build 1.3

This PR has a small fix that seems to solve such issue as stated by @bjscheue in #12159 (comment)

Test Scenarios

CI and using IDE to build basic sketches.

Related links

Closes #12159

@SuGlider SuGlider added this to the 3.3.0 milestone Dec 31, 2025
@SuGlider SuGlider self-assigned this Dec 31, 2025
@SuGlider SuGlider added the IDE: Arduino IDE Issue relates to Arduino IDE label Dec 31, 2025
@SuGlider SuGlider requested a review from me-no-dev as a code owner December 31, 2025 12:48
@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f431bb2

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/BLE/examples/Server--00----00--0000
libraries/Insights/examples/MinimalDiagnostics------0000----00
libraries/NetworkClientSecure/examples/WiFiClientSecure--00--0000----00
libraries/ESP32/examples/Camera/CameraWebServer------00------00
ESP32/examples/Camera/CameraWebServer (2)------00------00
ESP32/examples/Camera/CameraWebServer (3)----------------

@SuGlider SuGlider moved this from Todo to Under investigation in Arduino ESP32 Core Project Roadmap Dec 31, 2025
Added a note about whitespace to avoid bugs in older versions of arduino-builder.
Copy link

@bjscheue bjscheue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last addition to the comment is wrong. It's not about the line length, there is no 500 character limit. It's about the parser in arduino-builder processing the line incorrectly if there is a quote (') character that is directly followed by a whitespace.

@SuGlider
Copy link
Collaborator Author

SuGlider commented Jan 1, 2026

The last addition to the comment is wrong. It's not about the line length, there is no 500 character limit. It's about the parser in arduino-builder processing the line incorrectly if there is a quote (') character that is directly followed by a whitespace.

Thanks! Done.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a compatibility issue with Arduino IDE 1.x on Linux and CI systems using arduino-builder version 1.3. The issue manifested as a bash parsing error ("unexpected EOF while looking for matching `''") when building sketches, caused by how older arduino-builder versions handle quotes followed by whitespace in platform.txt recipe patterns.

Key Changes:

  • Removed whitespace around redirection operators (>, >>) and logical AND operators (&&) in the bash command that generates the flash_args file
  • Added an explanatory comment documenting the workaround for the arduino-builder bug

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider
Copy link
Collaborator Author

SuGlider commented Jan 7, 2026

@bjscheue - It doesn't work with Arduino IDE 2.

@SuGlider SuGlider marked this pull request as draft January 7, 2026 19:36
@SuGlider
Copy link
Collaborator Author

SuGlider commented Jan 7, 2026

@bjscheue - It doesn't work with Arduino IDE 2.

Retesting it again. It seems that Arduino IDE got lost with the changes. It may work fine.

@SuGlider
Copy link
Collaborator Author

SuGlider commented Jan 7, 2026

I have tested it with Win11 and IDE 2.3.7 + IDE 1.8.19 -- all fine so far.
I also tested it with Ubuntu and IDE 1.8.19 -- all good too.

@SuGlider SuGlider marked this pull request as ready for review January 7, 2026 20:04
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Jan 12, 2026
@me-no-dev me-no-dev merged commit e3721cf into master Jan 12, 2026
21 checks passed
@github-project-automation github-project-automation bot moved this from Under investigation to Done in Arduino ESP32 Core Project Roadmap Jan 12, 2026
@me-no-dev me-no-dev deleted the fix/old_arduino_build_compatibility branch January 12, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IDE: Arduino IDE Issue relates to Arduino IDE Status: Pending Merge Pull Request is ready to be merged

Projects

Development

Successfully merging this pull request may close these issues.

[Linux] build with IDE 1.x for ESP32-P4 is broken in Core 3.3.5

5 participants