Skip to content

feat(board): Add custom boards YB-ESP32-S3-AMP and YB-ESP32-S3-DAC#12191

Merged
me-no-dev merged 2 commits intoespressif:masterfrom
yellobyte:master
Jan 12, 2026
Merged

feat(board): Add custom boards YB-ESP32-S3-AMP and YB-ESP32-S3-DAC#12191
me-no-dev merged 2 commits intoespressif:masterfrom
yellobyte:master

Conversation

@yellobyte
Copy link
Contributor

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Description of Change

Two new Yellobyte boards YB-ESP32-S3-AMP and YB-ESP32-S3-DAC added to board list.
Verified that the defined pins correspond to the correct hardware pins on the board.

Test Scenarios

ArduinoIDE builds successfully tested with this board on actual Arduino-esp32 core revisions 3.3.x.

Related links

Two new boards coming soon. Resp. board info will be released on https://github.com/yellobyte in due time.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "add boards yb_esp32s3_amp and yb_esp32s3_dac":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello yellobyte, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d10d8db

@lucasssvaz lucasssvaz added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Dec 31, 2025
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yellobyte Hi, PTAL on my comments. Also maybe its same for the DAC version, can't find what module is used there.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Awaiting Response Awaiting a response from the author label Jan 5, 2026
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Awaiting Response Awaiting a response from the author labels Jan 5, 2026
@me-no-dev me-no-dev merged commit b929eb4 into espressif:master Jan 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants