Skip to content

feat(udp): Allow for packets up to 1460 bytes#12232

Merged
me-no-dev merged 1 commit intomasterfrom
feat/udp_mss
Jan 13, 2026
Merged

feat(udp): Allow for packets up to 1460 bytes#12232
me-no-dev merged 1 commit intomasterfrom
feat/udp_mss

Conversation

@me-no-dev
Copy link
Member

This pull request updates the maximum segment size configuration for UDP operations in the AsyncUDP.cpp file. The changes ensure that UDP-related buffer allocations and data transmissions use the correct maximum segment size constant, improving protocol correctness and maintainability.

Configuration updates:

  • Added a new constant definition for CONFIG_UDP_MSS set to 1460 to specify the maximum segment size for UDP.
  • Updated buffer allocation logic in the AsyncUDPMessage constructor to use CONFIG_UDP_MSS instead of CONFIG_TCP_MSS, ensuring UDP messages do not exceed the appropriate segment size.
  • Modified the AsyncUDP::writeTo method to use CONFIG_UDP_MSS for limiting the length of outgoing UDP packets, replacing the previous use of CONFIG_TCP_MSS.

Fixes: #12162

@github-actions
Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6de21b5

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C5000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32P4000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32S3000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32ESP32C3ESP32C5ESP32C6ESP32P4ESP32S2ESP32S3
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/AsyncUDP/examples/AsyncUDPClient00000000000000
libraries/AsyncUDP/examples/AsyncUDPMulticastServer00000000000000
libraries/AsyncUDP/examples/AsyncUDPServer0000--00000000
libraries/DNSServer/examples/CaptivePortal0000----0000--
libraries/NetBIOS/examples/ESP_NBNST0000----0000--
libraries/Update/examples/HTTP_Server_AES_OTA_Update0000----0000--

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

Test Results

 90 files   90 suites   32m 28s ⏱️
 67 tests  61 ✅ 0 💤 6 ❌
751 runs  744 ✅ 0 💤 7 ❌

For more details on these failures, see this check.

Results for commit 6de21b5.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Jan 13, 2026
Copy link
Member

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jan 13, 2026
@me-no-dev me-no-dev merged commit 02687f0 into master Jan 13, 2026
104 of 108 checks passed
@me-no-dev me-no-dev deleted the feat/udp_mss branch January 13, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CONFIG_TCP_MSS used in AsyncUDP.cpp causes truncated packets

4 participants