feat(udp): Allow for packets up to 1460 bytes#12232
Conversation
👋 Hello me-no-dev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Test Results 90 files 90 suites 32m 28s ⏱️ For more details on these failures, see this check. Results for commit 6de21b5. ♻️ This comment has been updated with latest results. |
This pull request updates the maximum segment size configuration for UDP operations in the
AsyncUDP.cppfile. The changes ensure that UDP-related buffer allocations and data transmissions use the correct maximum segment size constant, improving protocol correctness and maintainability.Configuration updates:
CONFIG_UDP_MSSset to 1460 to specify the maximum segment size for UDP.AsyncUDPMessageconstructor to useCONFIG_UDP_MSSinstead ofCONFIG_TCP_MSS, ensuring UDP messages do not exceed the appropriate segment size.AsyncUDP::writeTomethod to useCONFIG_UDP_MSSfor limiting the length of outgoing UDP packets, replacing the previous use ofCONFIG_TCP_MSS.Fixes: #12162