Skip to content

fix(example): Update GetMacddress.ino for 8 and 2 byte MACs#12262

Merged
me-no-dev merged 2 commits intomasterfrom
bugfix/get_mac_addr_sketch
Jan 21, 2026
Merged

fix(example): Update GetMacddress.ino for 8 and 2 byte MACs#12262
me-no-dev merged 2 commits intomasterfrom
bugfix/get_mac_addr_sketch

Conversation

@me-no-dev
Copy link
Member

This pull request enhances the GetMacAddress example for ESP32 by adding support for devices that include IEEE 802.15.4 (Thread/Zigbee) and external MAC addresses, and by updating the code to handle both 6-byte and 8-byte MAC addresses when relevant. The changes ensure the example works correctly on more ESP32 variants and displays the correct MAC address format depending on the interface.

Support for additional MAC address types and formats:

  • Updated the output header in setup() to clarify that MAC addresses may be 6 or 8 bytes, reflecting the new interface support.
  • Added conditional code to print IEEE802154 and EXT MAC addresses if the platform supports IEEE 802.15.4, using esp_read_mac for these interfaces.

Generalization for variable MAC address lengths:

  • Modified the getDefaultMacAddress() and getInterfaceMacAddress() functions to use 8-byte buffers and dynamically format either 6-byte or 8-byte MAC addresses, depending on the interface and configuration. [1] [2]

Fixes: #12255

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f2264f7

@github-actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32000.000.00000.000.00
ESP32C3💚 -400.000.00000.000.00
ESP32C5000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H20⚠️ +2980.00⚠️ +0.11000.000.00
ESP32P4💚 -400.000.00000.000.00
ESP32S2💚 -400.000.00000.000.00
ESP32S3000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32ESP32C3ESP32C5ESP32C6ESP32H2ESP32P4ESP32S2ESP32S3
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ESP32/examples/MacAddress/GetMacAddress00💚 -40----⚠️ +2980💚 -40💚 -40--

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Jan 19, 2026
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jan 21, 2026
@me-no-dev me-no-dev merged commit a95ef79 into master Jan 21, 2026
17 checks passed
@me-no-dev me-no-dev deleted the bugfix/get_mac_addr_sketch branch January 21, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetMacAddress.ino example sketch does not return 8 byte default MAC on ESP with 802.15.4 capability

2 participants