Skip to content

fix(dhcp): Fix DHCP Captive Portal URL#12263

Merged
me-no-dev merged 1 commit intomasterfrom
bugfix/captive_portal_url
Jan 21, 2026
Merged

fix(dhcp): Fix DHCP Captive Portal URL#12263
me-no-dev merged 1 commit intomasterfrom
bugfix/captive_portal_url

Conversation

@me-no-dev
Copy link
Member

@me-no-dev me-no-dev commented Jan 19, 2026

This pull request makes a minor improvement to the logging in the DHCP captive portal setup. It updates how the local IP address is converted to a string and adds a log statement to output the captive portal URL.

  • Improved string conversion for the local IP address and added a log statement to display the DHCP Captive Portal URL in enableDhcpCaptivePortal() in AP.cpp.

Reported: #11399 (comment)

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Jan 19, 2026
@me-no-dev me-no-dev mentioned this pull request Jan 19, 2026
Closed
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against bbdd743

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026 •
edited
Loading

Test Results

 90 files   90 suites   33m 7s ⏱️
 67 tests  67 ✅ 0 💤 0 ❌
683 runs  683 ✅ 0 💤 0 ❌

Results for commit bbdd743.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP320⚠️ +4440.00⚠️ +0.05000.000.00
ESP32C30⚠️ +7940.00⚠️ +0.08000.000.00
ESP32C5000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32P40⚠️ +7980.00⚠️ +0.09000.000.00
ESP32S20⚠️ +4640.00⚠️ +0.05000.000.00
ESP32S3000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32ESP32C3ESP32C5ESP32C6ESP32H2ESP32P4ESP32S2ESP32S3
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ArduinoOTA/examples/BasicOTA00000000--000000
libraries/ArduinoOTA/examples/SignedOTA00000000--000000
libraries/AsyncUDP/examples/AsyncUDPClient00000000--000000
libraries/AsyncUDP/examples/AsyncUDPMulticastServer00000000--000000
libraries/AsyncUDP/examples/AsyncUDPServer0000--00--000000
libraries/DNSServer/examples/CaptivePortal⚠️ +4440⚠️ +7940------⚠️ +7980⚠️ +4640--
libraries/ESP32/examples/Camera/CameraWebServer00----------00--
ESP32/examples/Camera/CameraWebServer (2)00----------00--
libraries/ESP32/examples/Time/SimpleTime0000------0000--
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Master0000--------00--
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Slave0000--------00--
libraries/ESP_NOW/examples/ESP_NOW_Network0000--------00--
libraries/ESP_NOW/examples/ESP_NOW_Serial0000--------00--
libraries/ESPmDNS/examples/mDNS-SD_Extended0000------0000--
libraries/ESPmDNS/examples/mDNS_Web_Server0000------0000--
libraries/Ethernet/examples/ETH_WIFI_BRIDGE0000------0000--
libraries/FFat/examples/FFat_time0000------0000--
libraries/HTTPClient/examples/Authorization0000------0000--
libraries/HTTPClient/examples/BasicHttpClient0000------0000--
libraries/HTTPClient/examples/BasicHttpsClient0000------0000--
libraries/HTTPClient/examples/CustomHeaders0000------0000--
libraries/HTTPClient/examples/HTTPClientEnterprise0000--------00--
libraries/HTTPClient/examples/ReuseConnection0000------0000--
libraries/HTTPClient/examples/StreamHttpClient0000------0000--
libraries/HTTPUpdate/examples/httpUpdate0000------0000--
libraries/HTTPUpdate/examples/httpUpdateSPIFFS0000------0000--
libraries/HTTPUpdate/examples/httpUpdateSecure0000------0000--
libraries/HTTPUpdateServer/examples/WebUpdater0000------0000--
libraries/Insights/examples/DiagnosticsSmokeTest0000--------00--
libraries/Insights/examples/MinimalDiagnostics0000--------00--
libraries/LittleFS/examples/LITTLEFS_time0000------0000--
libraries/Matter/examples/MatterColorLight0000----00--00--
libraries/Matter/examples/MatterCommissionTest0000----00--00--
libraries/Matter/examples/MatterComposedLights0000----00--00--
libraries/Matter/examples/MatterContactSensor0000----00--00--
libraries/Matter/examples/MatterDimmableLight0000----00--00--
libraries/Matter/examples/MatterDimmablePlugin0000----00--00--
libraries/Matter/examples/MatterEnhancedColorLight0000----00--00--
libraries/Matter/examples/MatterEvents0000----00--00--
libraries/Matter/examples/MatterFan0000----00--00--
libraries/Matter/examples/MatterHumiditySensor0000----00--00--
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs0000----00--00--
libraries/Matter/examples/MatterMinimum0000----00--00--
libraries/Matter/examples/MatterOccupancySensor0000----00--00--
libraries/Matter/examples/MatterOccupancyWithHoldTime0000----00--00--
libraries/Matter/examples/MatterOnIdentify0000----00--00--
libraries/Matter/examples/MatterOnOffLight0000----00--00--
libraries/Matter/examples/MatterOnOffPlugin0000----00--00--
libraries/Matter/examples/MatterPressureSensor0000----00--00--
libraries/Matter/examples/MatterRainSensor0000----00--00--
libraries/Matter/examples/MatterSimpleBlinds0000----00--00--
libraries/Matter/examples/MatterSmartButton0000----00--00--
libraries/Matter/examples/MatterStatus0000----00--00--
libraries/Matter/examples/MatterTemperatureControlledCabinet0000----00--00--
libraries/Matter/examples/MatterTemperatureControlledCabinetLevels0000----00--00--
libraries/Matter/examples/MatterTemperatureLight0000----00--00--
libraries/Matter/examples/MatterTemperatureSensor0000----00--00--
libraries/Matter/examples/MatterThermostat0000----00--00--
libraries/Matter/examples/MatterWaterFreezeDetector0000----00--00--
libraries/Matter/examples/MatterWaterLeakDetector0000----00--00--
libraries/Matter/examples/MatterWindowCovering0000----00--00--
libraries/NetBIOS/examples/ESP_NBNST0000------0000--
libraries/NetworkClientSecure/examples/WiFiClientInsecure0000------0000--
libraries/NetworkClientSecure/examples/WiFiClientPSK0000------0000--
libraries/NetworkClientSecure/examples/WiFiClientSecure0000------0000--
libraries/NetworkClientSecure/examples/WiFiClientSecureEnterprise0000--------00--
libraries/NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade0000------0000--
libraries/NetworkClientSecure/examples/WiFiClientShowPeerCredentials0000------0000--
libraries/NetworkClientSecure/examples/WiFiClientTrustOnFirstUse0000------0000--
libraries/PPP/examples/PPP_WIFI_BRIDGE0000------0000--
libraries/SD/examples/SD_time0000------0000--
libraries/SD_MMC/examples/SDMMC_time00--------00----
libraries/SPIFFS/examples/SPIFFS_time0000------0000--
libraries/Update/examples/AWS_S3_OTA_Update0000------0000--
libraries/Update/examples/HTTPS_OTA_Update0000------0000--
libraries/Update/examples/HTTP_Client_AES_OTA_Update0000------0000--
libraries/Update/examples/HTTP_Server_AES_OTA_Update0000------0000--
libraries/Update/examples/OTAWebUpdater0000------0000--
libraries/Update/examples/Signed_OTA_Update0000------0000--
libraries/WebServer/examples/AdvancedWebServer0000------0000--
libraries/WebServer/examples/ChunkWriting0000------0000--
libraries/WebServer/examples/FSBrowser0000------0000--
libraries/WebServer/examples/Filters0000------0000--
libraries/WebServer/examples/HelloServer0000------0000--
libraries/WebServer/examples/HttpAdvancedAuth0000------0000--
libraries/WebServer/examples/HttpAuthCallback0000------0000--
libraries/WebServer/examples/HttpAuthCallbackInline0000------0000--
libraries/WebServer/examples/HttpBasicAuth0000------0000--
libraries/WebServer/examples/HttpBasicAuthSHA10000------0000--
libraries/WebServer/examples/HttpBasicAuthSHA1orBearerToken0000------0000--
libraries/WebServer/examples/Middleware0000--------00--
libraries/WebServer/examples/MultiHomedServers0000------0000--
libraries/WebServer/examples/PathArgServer0000------0000--
libraries/WebServer/examples/SDWebServer0000------0000--
libraries/WebServer/examples/SimpleAuthentification0000------0000--
libraries/WebServer/examples/UploadHugeFile0000------0000--
libraries/WebServer/examples/WebServer0000------0000--
libraries/WebServer/examples/WebUpdate0000------0000--
libraries/WiFi/examples/FTM/FTM_Initiator0000------0000--
libraries/WiFi/examples/FTM/FTM_Responder0000------0000--
libraries/WiFi/examples/SimpleWiFiServer0000------0000--
libraries/WiFi/examples/WPS0000--------00--
libraries/WiFi/examples/WiFiAccessPoint0000------0000--
libraries/WiFi/examples/WiFiBlueToothSwitch0000------------
libraries/WiFi/examples/WiFiClient0000------0000--
libraries/WiFi/examples/WiFiClientBasic0000------0000--
libraries/WiFi/examples/WiFiClientConnect0000------0000--
libraries/WiFi/examples/WiFiClientEnterprise0000--------00--
libraries/WiFi/examples/WiFiClientEvents0000------0000--
libraries/WiFi/examples/WiFiClientStaticIP0000------0000--
libraries/WiFi/examples/WiFiExtender0000------0000--
libraries/WiFi/examples/WiFiIPv60000------0000--
libraries/WiFi/examples/WiFiMulti0000------0000--
libraries/WiFi/examples/WiFiMultiAdvanced0000------0000--
libraries/WiFi/examples/WiFiScan0000------0000--
libraries/WiFi/examples/WiFiScanAsync0000------0000--
libraries/WiFi/examples/WiFiScanDualAntenna0000------0000--
libraries/WiFi/examples/WiFiScanTime0000------0000--
libraries/WiFi/examples/WiFiSmartConfig0000--------00--
libraries/WiFi/examples/WiFiTelnetToSerial0000------0000--
libraries/WiFi/examples/WiFiUDPClient0000------0000--
libraries/WiFiProv/examples/WiFiProv0000--------00--
libraries/Zigbee/examples/Zigbee_Gateway0000--------00--
libraries/RainMaker/examples/RMakerCustom--00--------00--
libraries/RainMaker/examples/RMakerCustomAirCooler--00--------00--
libraries/RainMaker/examples/RMakerSonoffDualR3--00--------00--
libraries/RainMaker/examples/RMakerSwitch--00--------00--
libraries/ESP_HostedOTA/examples/ESP_HostedOTA----------00----
ESP32/examples/Camera/CameraWebServer (3)----------------

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jan 21, 2026
@me-no-dev me-no-dev merged commit 71a93cc into master Jan 21, 2026
107 of 111 checks passed
@me-no-dev me-no-dev deleted the bugfix/captive_portal_url branch January 21, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasssvaz lucasssvaz lucasssvaz approved these changes

Assignees

No one assigned

Labels

Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@me-no-dev @lucasssvaz