fix(hosted): Make BLE work on older hosted firmwares#12270
Merged
Conversation
Contributor
👋 Hello me-no-dev, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds version compatibility checks for BLE operations on ESP-Hosted firmware to prevent errors when running on older firmware versions (< 2.6.0). The changes ensure that Bluetooth controller initialization and deinitialization are only performed when the slave firmware supports these operations.
Changes:
- Added firmware version checks (>= 2.6.0) before BLE controller initialization and enabling
- Added firmware version checks (>= 2.6.0) before BLE controller disabling and deinitialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lucasssvaz
approved these changes
Jan 21, 2026
Contributor
Test Results 90 files 90 suites 33m 39s ⏱️ Results for commit 3e19571. ♻️ This comment has been updated with latest results. |
Contributor
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the BLE initialization and deinitialization logic in
cores/esp32/esp32-hal-hosted.cto ensure that Bluetooth controller operations are only performed if the slave firmware version meets a minimum requirement. This helps maintain compatibility and prevents errors on older firmware versions.Version compatibility checks for BLE operations:
hostedInitBLE()to only initialize and enable the Bluetooth controller if the slave firmware version is at least 2.6.0. [1] [2]hostedDeinitBLE()to only disable and deinitialize the Bluetooth controller if the slave firmware version is at least 2.6.0. [1] [2]