fix(ota): Show MD5 warning only when connection is successful

[lucasssvaz]

Description of Change

This pull request improves the authentication flow and user feedback in the tools/espota.py script, particularly around password hashing methods for device compatibility. The most important changes include enhanced logging for insecure MD5 usage, clearer authentication status messages, and improved guidance for users when authentication fails.

Authentication flow and user feedback improvements:

• Added warnings after successful MD5-based authentication to inform users about insecure password hashing and encourage upgrading devices to ESP32 Arduino Core 3.3.1+ for better security.
• Improved standard error messages to indicate which authentication method is being used (e.g., "Authenticating (PBKDF2-HMAC-SHA256)...", "Authenticating (MD5)...") and clarified retry attempts. [1] [2] [3]

Error handling enhancements:

• Added explicit suggestions in error logs to "Please check your password and try again" when authentication fails, making troubleshooting easier for users. [1] [2]

Codebase cleanup:

• Moved legacy MD5 warning logs from the authenticate function to the main authentication flow, ensuring warnings are only shown when MD5 is actually used. [1] [2]

Test Scenarios

Tested locally

Related links

Closes #12261

[github-actions]

	Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3a7076a