fix(ble): Make BLE memory management automatic#12287
Merged
Merged
Conversation
lucasssvaz
requested review from
a team,
SuGlider and
me-no-dev
as code owners
Contributor
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Contributor
Test Results 90 files 90 suites 33m 56s ⏱️ Results for commit adaff17. ♻️ This comment has been updated with latest results. |
lucasssvaz
force-pushed
the
fix/ble_mem
branch
from
b140169 to
4fe8e69
Compare
Contributor
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
P-R-O-C-H-Y
approved these changes
Jan 29, 2026
me-no-dev
approved these changes
Feb 9, 2026
me-no-dev
added
Status: Pending Merge
6 tasks
Contributor
|
@lucasssvaz @me-no-dev I just updated my project from 3.0.7 to 3.3.8. When I did, code that worked before the update was suddenly bricking my devices. Needed to put them in boot mode to recover them. Took me awhile to narrow the problem down to BLE, and narrow the problem down the 3.3.7, and narrow it down to this PR. My project uses ArduinoBLE which does not have the new header file included yet. This PR is a breaking change for ArduinoBLE and libraries like it. |
Member
Author
|
@SaintSampo You can override the memory management if needed https://github.com/espressif/arduino-esp32/blob/master/cores/esp32/esp32-hal-bt.c#L23-L28. The proper fix is to include esp32-hal-bt-mem.h in ArduinoBLE. This was broken before and now is fixed. |
Contributor
|
Yea it was easy enough for me to include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request refactors how Bluetooth (BT) controller memory is managed and detected in the ESP32 Arduino core. It introduces a new mechanism for automatically detecting when BT libraries are linked, allowing the core to release unused BT memory by default unless a BT library is present or the user explicitly overrides the behavior. Additionally, it removes the
free_bt_memoryexample and its associated files, as the new mechanism makes manual overrides less necessary.Core changes to BT memory management:
esp32-hal-bt-mem.hthat defines a constructor to automatically set a flag (_btLibraryInUse) when any BT library is linked, allowing the core to detect BT usage at link time.btInUse()inesp32-hal-bt.cto return the value of_btLibraryInUseinstead of always keeping BT memory; users can still override this function if needed. [1] [2]BLEDevice.cpp,BluetoothSerial.cpp,SimpleBLE.cpp) to include the newesp32-hal-bt-mem.hheader, ensuring the flag is set when these libraries are used. [1] [2] [3]Removal of
free_bt_memoryexample:idf_component_examples/free_bt_memoryexample, including its configuration, source code, and documentation, as the new automatic detection makes it obsolete. [1] [2] [3] [4] [5] [6] [7] [8]FreeBTMemoryexample from the BLE library and its CI configuration. [1] [2]Minor API improvement:
BLEDevice::init()method signature to provide a default argument, improving usability.Test Scenarios
Tested locally with Hello world.
Before fix:
HEAP:lifetime min:4399796, larg. free bl.:4128756, free:4404756 (alloc: 35916), blocks free: 6 (alloc: 93, total: 99), STACK:lifetime min: 7172 (8192)After fix:
HEAP:lifetime min:4418508, larg. free bl.:4128756, free:4423468 (alloc: 35916), blocks free: 6 (alloc: 93, total: 99), STACK:lifetime min: 7180 (8192)Around +20kB of free heap.
Related links
Closes #12284