Skip to content

ci(push): Optimize chunk counting to avoid empty chunks#12295

Merged
me-no-dev merged 1 commit into
espressif:masterfrom
lucasssvaz:fix/compilation_optimization
Feb 9, 2026
Merged

ci(push): Optimize chunk counting to avoid empty chunks#12295
me-no-dev merged 1 commit into
espressif:masterfrom
lucasssvaz:fix/compilation_optimization

Conversation

@lucasssvaz
Copy link
Copy Markdown
Member

Description of Change

This pull request updates the chunking logic in the set_ci_output function within .github/scripts/get_affected.py to better distribute sketches across CI chunks. The new approach ensures that chunks are created only as needed, preventing empty chunks and aligning with the logic used in sketch_utils.sh.

Improvements to CI chunk calculation:

  • Updated the chunking algorithm to create one chunk per sketch when the number of sketches is less than or equal to the maximum allowed chunks, and to distribute sketches evenly across chunks when there are more sketches than the maximum, using ceiling division to avoid empty chunks.
  • Added informative print statements to clarify how chunks are being allocated based on the number of sketches and maximum chunks.

Test Scenarios

Tested locally

@lucasssvaz lucasssvaz self-assigned this Jan 30, 2026
@lucasssvaz lucasssvaz added the Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. label Jan 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against ef4f53d

@lucasssvaz lucasssvaz added the Status: Review needed Issue or PR is awaiting review label Jan 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C5000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32P4000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32S3000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32ESP32C3ESP32C5ESP32C6ESP32H2ESP32P4ESP32S2ESP32S3
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/BLE/examples/Server000000000000--00
libraries/ESP32/examples/Camera/CameraWebServer00----------0000
ESP32/examples/Camera/CameraWebServer (2)00----------0000
libraries/Insights/examples/MinimalDiagnostics00000000----0000
libraries/NetworkClientSecure/examples/WiFiClientSecure00000000--000000
ESP32/examples/Camera/CameraWebServer (3)--------------00

Copy link
Copy Markdown
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Feb 9, 2026
@me-no-dev me-no-dev merged commit 1c8c57d into espressif:master Feb 9, 2026
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants